Groups > linux.kernel > #1200553

Re: [PATCH 1/3] x86/entry/64: Refactor IRQ stacks and make then NMI-safe

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] x86/entry/64: Refactor IRQ stacks and make then NMI-safe
Date	2015-08-05 11:10 +0200
Message-ID	<pU2RY-5aV-11@gated-at.bofh.it> (permalink)
References	<pPxjH-3z4-1@gated-at.bofh.it> <pPxjI-3z4-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Andy Lutomirski <luto@kernel.org> wrote:

> --- a/arch/x86/kernel/process_64.c
> +++ b/arch/x86/kernel/process_64.c
> @@ -280,6 +280,10 @@ __switch_to(struct task_struct *prev_p, struct task_struct *next_p)
>  	unsigned fsindex, gsindex;
>  	fpu_switch_t fpu_switch;
>  
> +#ifdef CONFIG_DEBUG_ENTRY
> +	WARN_ON(this_cpu_read(irq_count));
> +#endif

Please introduce a less noisy (to the eyes) version of this, something like:

	WARN_ON_DEBUG_ENTRY(this_cpu_read(irq_count));

or so, similar to WARN_ON_FPU().

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] x86/entry/64: Refactor IRQ stacks and make then  NMI-safe Ingo Molnar <mingo@kernel.org> - 2015-08-05 11:10 +0200
  Re: [PATCH 1/3] x86/entry/64: Refactor IRQ stacks and make then NMI-safe Andy Lutomirski <luto@amacapital.net> - 2015-08-05 20:30 +0200
    Re: [PATCH 1/3] x86/entry/64: Refactor IRQ stacks and make then  NMI-safe Steven Rostedt <rostedt@goodmis.org> - 2015-08-05 20:30 +0200
      Re: [PATCH 1/3] x86/entry/64: Refactor IRQ stacks and make then NMI-safe Andy Lutomirski <luto@amacapital.net> - 2015-08-05 20:40 +0200

csiph-web