Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1200541

Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration support

Show all headers | View raw

On Tuesday 21 July 2015 06:11 PM, Vaibhav Hiremath wrote:
> With addition of PXA910 family of devices, the TWSI module supports
> SCL clock adjustment using ILCR register.
>
> This patch enables the control and configuration of ICLR through DT
> properties,
>
> i2c-sclk-high-time-ns:
>    SCLK high time (tHigh), for standard/fast/high speed mode
> i2c-sclk-low-time-ns:
>    SCLK low time (tLow), for standard/fast/high speed mode
>
> Note that in case of standard and fast mod, the tLow and tHigh counters
> are same, and software will use tLow value.
>
> Also, brought up devm_clk_get() fn above i2c_pxa_probe_dt(), as it
> uses clk rate for timing calculations.
>
> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
> Signed-off-by: Jett.Zhou <jtzhou@marvell.com>
> Signed-off-by: Yi Zhang <yizhang@marvell.com>
> ---
>   drivers/i2c/busses/i2c-pxa.c | 69 ++++++++++++++++++++++++++++++++++++++++----
>   1 file changed, 63 insertions(+), 6 deletions(-)
>

Robert,

It would be helpful if you can test this patch-series and confirm that
it now fixes the NULL pointer deference issue.

Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration  support Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-05 11:00 +0200
  Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration support Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-05 21:20 +0200
    Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration  support Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-06 07:50 +0200
  Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration support Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-09 14:30 +0200
    Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration  support Vaibhav Hiremath <vaibhav.hiremath@linaro.org> - 2015-08-09 19:00 +0200

csiph-web