Groups > linux.kernel > #1200502

Re: [PATCH v3 1/1] x86: allow to enable/disable modify_ldt at run time

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/1] x86: allow to enable/disable modify_ldt at run time
Date	2015-08-05 10:10 +0200
Message-ID	<pU1VT-3PS-13@gated-at.bofh.it> (permalink)
References	<pTsEO-2EE-29@gated-at.bofh.it> <pTGeK-5Af-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Willy Tarreau <w@1wt.eu> wrote:

> @@ -276,6 +282,15 @@ asmlinkage int sys_modify_ldt(int func, void __user *ptr,
>  {
>  	int ret = -ENOSYS;
>  
> +	if (!sysctl_modify_ldt) {
> +		printk_ratelimited(KERN_INFO
> +			"Denied a call to modify_ldt() from %s[%d] (uid: %d)."
> +			" Adjust sysctl if this was not an exploit attempt.\n",
> +			current->comm, task_pid_nr(current),
> +			from_kuid_munged(current_user_ns(), current_uid()));

UI nit: so this message should really tell the user _which_ sysctl to configure, 
instead of passive-aggressively alluding to the fact that there's a sysctl 
somewhere that might do the trick...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 1/1] x86: allow to enable/disable modify_ldt at run  time Ingo Molnar <mingo@kernel.org> - 2015-08-05 10:10 +0200
  Re: [PATCH v3 1/1] x86: allow to enable/disable modify_ldt at run time Willy Tarreau <w@1wt.eu> - 2015-08-05 10:10 +0200
    Re: [PATCH v3 1/1] x86: allow to enable/disable modify_ldt at run  time Ingo Molnar <mingo@kernel.org> - 2015-08-05 10:30 +0200
      Re: [PATCH v3 1/1] x86: allow to enable/disable modify_ldt at run time Willy Tarreau <w@1wt.eu> - 2015-08-05 11:10 +0200
        Re: [PATCH v3 1/1] x86: allow to enable/disable modify_ldt at run  time Ingo Molnar <mingo@kernel.org> - 2015-08-05 11:20 +0200

csiph-web