Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1199346

Re: [PATCH 2/4] perf, tools, stat: Abstract stat metrics printing

Show all headers | View raw

> 
> because we already need to make the print_metric callback global,
> would it be better to make this struct global, having all the
> needed callbacks defined within? something like:

It's actually not global, but static.

I skipped this change. After some other changes there is only
a single function call with these arguments left, so it's not 
an issue to pass it around.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/4] perf, tools, stat: Abstract stat metrics printing Andi Kleen <andi@firstfloor.org> - 2015-08-04 02:50 +0200

csiph-web