Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1199012

Re: [PATCH] MIPS: c-r4k: remove cpu_foreign_map

Show all headers | View raw

On Mon, Aug 03, 2015 at 08:54:47AM -0700, Paul Burton wrote:

> Commit cccf34e9411c ("MIPS: c-r4k: Fix cache flushing for MT cores") did
> 2 things:
> 
>   - Introduced cpu_foreign_map to call cache maintenance functions on
>     only a single CPU within each core in the system.
> 
>   - Stopped calling cache maintenance functions on non-local CPUs for
>     systems which include a MIPS Coherence Manager.
> 
> Thus the introduction of cpu_foreign_map has no effect on any systems
> with a CM, since the IPIs will be avoided entirely. Thus it can only
> possibly affect other systems which have multiple logical CPUs per core,
> which appears to only be netlogic. I'm pretty certain this wasn't the
> intent, am unsure whether avoiding such cache maintenance calls is
> correct for netlogic systems and believe the overhead of calculating
> cpu_foreign_map is thus unnecessary & this code is almost certainly
> untested.
> 
> This mostly reverts commit cccf34e9411c ("MIPS: c-r4k: Fix cache
> flushing for MT cores"), leaving only the change for systems with a CM.

BMIPS is another "hyperthreading-like" core.  Maybe Kevin or Florian
can comment if this patch is good for them?

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] MIPS: c-r4k: remove cpu_foreign_map Paul Burton <paul.burton@imgtec.com> - 2015-08-03 18:00 +0200
  Re: [PATCH] MIPS: c-r4k: remove cpu_foreign_map Ralf Baechle <ralf@linux-mips.org> - 2015-08-03 18:20 +0200

csiph-web