Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1198838
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 04/10] nohz: Remove useless argument on tick_nohz_task_switch() |
| Date | 2015-08-03 15:10 +0200 |
| Message-ID | <pTnF8-3WH-13@gated-at.bofh.it> (permalink) |
| References | <pPrQZ-3Wb-3@gated-at.bofh.it> <pPrR1-3Wb-19@gated-at.bofh.it> <pTnlL-3kJ-21@gated-at.bofh.it> <pTnvr-3w4-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Aug 03, 2015 at 02:49:54PM +0200, Frederic Weisbecker wrote: > On Mon, Aug 03, 2015 at 02:39:59PM +0200, Peter Zijlstra wrote: > > On Thu, Jul 23, 2015 at 06:42:09PM +0200, Frederic Weisbecker wrote: > > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > > index 78b4bad10..4d34035 100644 > > > --- a/kernel/sched/core.c > > > +++ b/kernel/sched/core.c > > > @@ -2489,7 +2489,7 @@ static struct rq *finish_task_switch(struct task_struct *prev) > > > put_task_struct(prev); > > > } > > > > > > - tick_nohz_task_switch(current); > > > + tick_nohz_task_switch(); > > > return rq; > > > } > > > > OK, so I just noticed this one. Please explain? WTF does it make sense > > to have per task tick state? > > > > If we have >1 tasks, we need the tick. If we have 1 task, per-task == > > per-cpu. > > > > So what gives? > > tick_nohz_task_switch() is removed in the end of the patchset. There is no > more per task dependency after this specific set. OK, I'll keep reading ;-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [PATCH 04/10] nohz: Remove useless argument on tick_nohz_task_switch() Peter Zijlstra <peterz@infradead.org> - 2015-08-03 14:50 +0200
Re: [PATCH 04/10] nohz: Remove useless argument on tick_nohz_task_switch() Frederic Weisbecker <fweisbec@gmail.com> - 2015-08-03 15:00 +0200
Re: [PATCH 04/10] nohz: Remove useless argument on tick_nohz_task_switch() Peter Zijlstra <peterz@infradead.org> - 2015-08-03 15:10 +0200
csiph-web