Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1198749

Re: [PATCH v5] powerpc/rcpm: add RCPM driver

From Chenhui Zhao <chenhui.zhao@freescale.com>
Newsgroups linux.kernel
Subject Re: [PATCH v5] powerpc/rcpm: add RCPM driver
Date 2015-08-03 13:20 +0200
Message-ID <pTlWG-1pW-7@gated-at.bofh.it> (permalink)
References <pFwyD-M5-35@gated-at.bofh.it> <pSt9T-5yr-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



On Sat, Aug 1, 2015 at 8:45 AM, Scott Wood <scottwood@freescale.com> 
wrote:
> On Fri, 2015-06-26 at 15:44 +0800, Yuantian.Tang@freescale.com wrote:
>>  +static void rcpm_v1_set_ip_power(bool enable, u32 *mask)
>>  +{
>>  +     if (enable)
>>  +             setbits32(&rcpm_v1_regs->ippdexpcr, *mask);
>>  +     else
>>  +             clrbits32(&rcpm_v1_regs->ippdexpcr, *mask);
>>  +}
>>  +
>>  +static void rcpm_v2_set_ip_power(bool enable, u32 *mask)
>>  +{
>>  +     if (enable)
>>  +             setbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
>>  +     else
>>  +             clrbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
>>  +}
> 
> Why do these take "u32 *mask" instead of "u32 mask"?
> 
> -Scott

I think it can be used in the case where there are several mask values.

-Chenhui

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v5] powerpc/rcpm: add RCPM driver Scott Wood <scottwood@freescale.com> - 2015-08-01 02:50 +0200
  Re: [PATCH v5] powerpc/rcpm: add RCPM driver Chenhui Zhao <chenhui.zhao@freescale.com> - 2015-08-03 13:20 +0200
    Re: [PATCH v5] powerpc/rcpm: add RCPM driver Scott Wood <scottwood@freescale.com> - 2015-08-03 22:30 +0200

csiph-web