Groups > linux.kernel > #1198742

Re: [PATCH v2] drm/i915: load driver even if debugfs fails

From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] drm/i915: load driver even if debugfs fails
Date	2015-08-03 13:00 +0200
Message-ID	<pTlDk-NT-11@gated-at.bofh.it> (permalink)
References	<pPpm9-v1-3@gated-at.bofh.it> <pTkee-7lf-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 03, 2015 at 02:56:42PM +0530, Sudip Mukherjee wrote:
> On Thu, Jul 23, 2015 at 07:36:12PM +0530, Sudip Mukherjee wrote:
> > debugfs files are not necessary for the usual operation of the driver
> > and the device. No need to check for the return values from the debugfs
> > file creation. Even if one debugfs file fails to create we try with the
> > next debugfs file and ultimately return success always so that the
> > driver continues to load.

Does this even happen? I'm reluctant to merge patches without real-world
justification.
-Daniel

> > cleanup will clean all the created debugfs files as the list of file
> > that are created are maintained in minor->debugfs_list.
> > 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> A gentle ping.
> 
> regards
> sudip
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v2] drm/i915: load driver even if debugfs fails Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-07-23 16:10 +0200
  Re: [PATCH v2] drm/i915: load driver even if debugfs fails Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-03 11:30 +0200
    Re: [PATCH v2] drm/i915: load driver even if debugfs fails Daniel Vetter <daniel@ffwll.ch> - 2015-08-03 13:00 +0200
      Re: [PATCH v2] drm/i915: load driver even if debugfs fails Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-08-03 13:50 +0200

csiph-web