Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1198593
| Path | csiph.com!optima2.xanadu-bbs.net!xanadu-bbs.net!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | yalin wang <yalin.wang2010@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal> |
| Date | Mon, 03 Aug 2015 09:30:01 +0200 |
| Message-ID | <pTim5-4Ds-5@gated-at.bofh.it> (permalink) |
| References | <pT83o-6i0-9@gated-at.bofh.it> |
| X-Original-To | Joe Perches <joe@perches.com> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=7yF0Q8GoCI8jfwGiQweoweb+/QKPx7qUG99eUnDh8yE=; b=FPe7qhs65CtZ3Csdvnm4xd9GCdFtmnpyrw25QApJgp2Ud9Y+anryS/sXa+YIdnyYSb uRHNGx9BTg8EhcXOWY1wlevDWFkNbAvWXMSE3AAHT+rmBUYHF90YAonl/Gxy/eN1dN0R OG4R9z7b7UnO/IpkWHxOm1xs7q7KP+cDXaZ5z8EeaK+wstQo97naar6EGqnuFG4QVwx6 3BxDS1anUNX12NLio3mDxEGMLPwRgdXRn5qIZH0UXEW4JvkGAqeqQIy8uqbfiuD77rYO 3sRew5x6CykKVY5ZBdhCj7oBLiu+w9A/W/wsr3dAB/YNPtAvQwPULoBEAsF0BeWQ3Xkf e1SQ== |
| X-Received | by 10.66.66.130 with SMTP id f2mr33728064pat.120.1438586744845; Mon, 03 Aug 2015 00:25:44 -0700 (PDT) |
| Content-Type | text/plain; charset=windows-1252 |
| MIME-Version | 1.0 (Mac OS X Mail 8.2 \(2098\)) |
| Content-Transfer-Encoding | 8BIT |
| X-Mailer | Apple Mail (2.2098) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 59 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Don Brace <don.brace@pmcs.com>, linux-kernel@vger.kernel.org, iss_storagedev@hp.com, storagedev@pmcs.com, linux-scsi <linux-scsi@vger.kernel.org> |
| X-Original-Date | Mon, 3 Aug 2015 15:25:38 +0800 |
| X-Original-Message-ID | <9547AF94-2168-4987-AD89-B7F111084CC2@gmail.com> |
| X-Original-References | <1438547113.29569.5.camel@perches.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1198593 |
Show key headers only | View raw
> On Aug 3, 2015, at 04:25, Joe Perches <joe@perches.com> wrote:
>
> Correct misuse of 0x%d in logging messages.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/block/DAC960.c | 4 ++--
> drivers/block/cciss.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c
> index 811e11c..d9b32f2 100644
> --- a/drivers/block/DAC960.c
> +++ b/drivers/block/DAC960.c
> @@ -2954,7 +2954,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device,
> case DAC960_PD_Controller:
> if (!request_region(Controller->IO_Address, 0x80,
> Controller->FullModelName)) {
> - DAC960_Error("IO port 0x%d busy for Controller at\n",
> + DAC960_Error("IO port 0x%x busy for Controller at\n",
> Controller, Controller->IO_Address);
> goto Failure;
> }
> @@ -2990,7 +2990,7 @@ DAC960_DetectController(struct pci_dev *PCI_Device,
> case DAC960_P_Controller:
> if (!request_region(Controller->IO_Address, 0x80,
> Controller->FullModelName)){
> - DAC960_Error("IO port 0x%d busy for Controller at\n",
> + DAC960_Error("IO port 0x%x busy for Controller at\n",
> Controller, Controller->IO_Address);
> goto Failure;
> }
> diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
> index 0422c47..2758982 100644
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -3854,7 +3854,7 @@ static void print_cfg_table(ctlr_info_t *h)
> readl(&(tb->HostWrite.CoalIntDelay)));
> dev_dbg(&h->pdev->dev, " Coalesce Interrupt Count = 0x%x\n",
> readl(&(tb->HostWrite.CoalIntCount)));
> - dev_dbg(&h->pdev->dev, " Max outstanding commands = 0x%d\n",
> + dev_dbg(&h->pdev->dev, " Max outstanding commands = 0x%x\n",
> readl(&(tb->CmdsOutMax)));
> dev_dbg(&h->pdev->dev, " Bus Types = 0x%x\n",
> readl(&(tb->BusTypes)));
> —
why not use like this : dev_dbg(&h->pdev->dev, " Max outstanding commands = %#x\n” ?
%#x will add 0x prefix automatically .
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[TRIVIAL PATCH] block: Correct misuses of 0x%<decimal> Joe Perches <joe@perches.com> - 2015-08-02 22:30 +0200
Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal> Johannes Thumshirn <jthumshirn@suse.de> - 2015-08-03 09:30 +0200
Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal> yalin wang <yalin.wang2010@gmail.com> - 2015-08-03 09:30 +0200
Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal> Joe Perches <joe@perches.com> - 2015-08-03 10:10 +0200
Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal> yalin wang <yalin.wang2010@gmail.com> - 2015-08-03 11:00 +0200
Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal> yalin wang <yalin.wang2010@gmail.com> - 2015-08-04 04:20 +0200
Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal> Joe Perches <joe@perches.com> - 2015-08-04 04:30 +0200
Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal> yalin wang <yalin.wang2010@gmail.com> - 2015-08-04 06:10 +0200
csiph-web