Groups > linux.kernel > #1198589

Re: [PATCH V2] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2] staging: android: lowmemorykiller: imporve lmk to avoid deadlock issue
Date	2015-08-03 09:20 +0200
Message-ID	<pTicp-4sl-9@gated-at.bofh.it> (permalink)
References	<pTgX0-2bC-13@gated-at.bofh.it> <pThgl-2NH-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 03, 2015 at 09:15:56AM +0300, Dan Carpenter wrote:
> > Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> I don't really feel comfortable saying I reviewed this code.  I just
> commented on a few process issues.  I don't know the subsystem well
> enough to give it a seal of approval.
> 

Biao was asking off list, how to fix this.  I guess just leave it.  I
more care about going forward that we don't start doing this all the
time.

I recently added a reviewed-by tag for someone.  He told me off list
that the patch "looks OK".  He was the subsystem expert and we were
patching his code so it was his responsibility to review the fix.  If
the patch breaks everyone's system then he's absolutely the guy that I
want people to blame.  :)

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH V2]  staging: android: lowmemorykiller: imporve lmk to avoid  deadlock issue "Wang, Biao" <biao.wang@intel.com> - 2015-08-03 08:00 +0200
  Re: [PATCH V2]  staging: android: lowmemorykiller: imporve lmk to  avoid deadlock issue Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-03 08:20 +0200
    Re: [PATCH V2]  staging: android: lowmemorykiller: imporve lmk to  avoid deadlock issue Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-03 09:20 +0200
    Re: [PATCH V2]  staging: android: lowmemorykiller: imporve lmk to  avoid deadlock issue Joe Perches <joe@perches.com> - 2015-08-03 10:00 +0200
  Re: [PATCH V2]  staging: android: lowmemorykiller: imporve lmk to  avoid deadlock issue Dave Hansen <dave.hansen@intel.com> - 2015-08-03 16:10 +0200

csiph-web