Groups > linux.kernel > #1198555

Re: [PATCH 11/15] drivers: target: Drop unlikely before IS_ERR(_OR_NULL)

From	"Nicholas A. Bellinger" <nab@linux-iscsi.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 11/15] drivers: target: Drop unlikely before IS_ERR(_OR_NULL)
Date	2015-08-03 07:50 +0200
Message-ID	<pTgNk-203-1@gated-at.bofh.it> (permalink)
References	<pSe1b-aE-3@gated-at.bofh.it> <pSeaR-mJ-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2015-07-31 at 14:08 +0530, Viresh Kumar wrote:
> IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
> is no need to do that again from its callers. Drop it.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  drivers/target/tcm_fc/tfc_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/target/tcm_fc/tfc_cmd.c b/drivers/target/tcm_fc/tfc_cmd.c
> index 68031723e5be..aa3caca8bace 100644
> --- a/drivers/target/tcm_fc/tfc_cmd.c
> +++ b/drivers/target/tcm_fc/tfc_cmd.c
> @@ -255,7 +255,7 @@ static void ft_recv_seq(struct fc_seq *sp, struct fc_frame *fp, void *arg)
>  	struct ft_cmd *cmd = arg;
>  	struct fc_frame_header *fh;
>  
> -	if (unlikely(IS_ERR(fp))) {
> +	if (IS_ERR(fp)) {
>  		/* XXX need to find cmd if queued */
>  		cmd->seq = NULL;
>  		cmd->aborted = true;

Looks fine.  Applied to target-pending/for-next.

Thanks Viresh!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 11/15] drivers: target: Drop unlikely before  IS_ERR(_OR_NULL) "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2015-08-03 07:50 +0200

csiph-web