Groups > linux.kernel > #1198531

Re: [PATCH] mm: add the block to the tail of the list in expand()

From	Dave Hansen <dave.hansen@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm: add the block to the tail of the list in expand()
Date	2015-08-03 06:20 +0200
Message-ID	<pTfod-8w2-1@gated-at.bofh.it> (permalink)
References	<pSeXg-1yJ-21@gated-at.bofh.it> <pSrUu-3Qk-13@gated-at.bofh.it> <pTdmq-5xR-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/02/2015 07:05 PM, Xishi Qiu wrote:
>> > Also, this might not do very much good in practice.  If you are
>> > splitting a high-order page, you are doing the split because the
>> > lower-order lists are empty.  So won't that list_add() be to an empty
> 
> I made a mistake, you are right, all the lower-order lists are empty,
> so it is no sense to add to the tail.

I actually tested this experimentally and the lists are not always
empty.  It's probably __rmqueue_smallest() vs. __rmqueue_fallback() logic.

In any case, you might want to double-check.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] mm: add the block to the tail of the list in expand() Xishi Qiu <qiuxishi@huawei.com> - 2015-08-03 04:10 +0200
  Re: [PATCH] mm: add the block to the tail of the list in expand() Dave Hansen <dave.hansen@intel.com> - 2015-08-03 06:20 +0200
    Re: [PATCH] mm: add the block to the tail of the list in expand() Xishi Qiu <qiuxishi@huawei.com> - 2015-08-04 03:20 +0200
      Re: [PATCH] mm: add the block to the tail of the list in expand() Dave Hansen <dave.hansen@intel.com> - 2015-08-04 16:30 +0200

csiph-web