Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1200186

Re: [PATCH v4 1/3] dt-binding: spi: Mediatek: Document devicetree bindings for spi bus

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Jul 29, 2015 at 07:04:32PM +0800, Leilk Liu wrote:
> Signed-off-by: Leilk Liu <leilk.liu@mediatek.com>

Please use subject lines reflecting the style for the subsystem so
people can spot if patches are relevant to them.

> +- clocks: phandles to input clocks.
> +
> +- clock-names: tuple listing input clock names.
> +	Required elements: "main"

...and there are no optional values?

> +- pad-select: should specify spi pad used, only required for MT8173.
> +        This value should be 0~3.

What do the values 0-3 mean?  I guess it's the value for some register
or other part of the device, the binding should say so people can go and
check the datasheet, schematic or whatever to figure out what to set.

This property should be optional, not required

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 1/3] dt-binding: spi: Mediatek: Document devicetree  bindings for spi bus Mark Brown <broonie@kernel.org> - 2015-08-04 19:50 +0200
  Re: [PATCH v4 1/3] dt-binding: spi: Mediatek: Document devicetree  bindings for spi bus leilk liu <leilk.liu@mediatek.com> - 2015-08-06 03:50 +0200

csiph-web