Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1200166

Re: [RFC PATCH v2] lib: scatterlist: add sg splitting function

Show all headers | View raw

Andrew Morton <akpm@linux-foundation.org> writes:

>>  include/linux/scatterlist.h |   5 ++
>>  lib/scatterlist.c           | 189 ++++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 194 insertions(+)
>
> It's quite a bit of code for a fairly specialised thing.  How ugly
> would it be to put this in a new .c file and have subsystems select it
> in Kconfig?
I have no idea about the "ugliness", but why not ...

If nobody objects, and in order to submit a proper patch, there are decisions to
make :
 - what will be the scope of this new .c file ?
   - only sg_plit() ?
   - all sg specialized functions, ie. sg_lib.c ?
 - will include/linux/scatterlist.h have an "ifdefed" portion for what X.c
   offers ?
 - what naming for X.c and the config entry ?

What about adding this to lib/Makefile, and one ifdef to scatterlist.h ? :
     obj-$(CONFIG_SG_LIB) += sg_lib.o

Cheers.

-- 
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH v2] lib: scatterlist: add sg splitting function Andrew Morton <akpm@linux-foundation.org> - 2015-08-04 01:20 +0200
  Re: [RFC PATCH v2] lib: scatterlist: add sg splitting function Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-04 19:10 +0200
    Re: [RFC PATCH v2] lib: scatterlist: add sg splitting function Andrew Morton <akpm@linux-foundation.org> - 2015-08-04 23:30 +0200

csiph-web