Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1200125

Re: [PATCH 1/7] phy: ti-pipe3: cleanup ti_pipe3_probe()

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Aug 04, 2015 at 08:50:40PM +0530, Kishon Vijay Abraham I wrote:
> No functional change. Add separate functions for pll,
> clocks and syscon to make ti_pipe3_probe clean.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

I think this needs to be splitted into smaller patches.

Seems like the very first patch would be to introduce a local struct
device pointer to be used. Than add each and every new function on their
own patch. This will help big time making your refactoring a lot clearer
and, should anything go wrong, we can atomically revert a specific
change, instead of loosing the entire refactor.

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/7] phy: ti-pipe3: cleanup ti_pipe3_probe() Kishon Vijay Abraham I <kishon@ti.com> - 2015-08-04 17:30 +0200
  Re: [PATCH 1/7] phy: ti-pipe3: cleanup ti_pipe3_probe() Felipe Balbi <balbi@ti.com> - 2015-08-04 18:10 +0200
    Re: [PATCH 1/7] phy: ti-pipe3: cleanup ti_pipe3_probe() Kishon Vijay Abraham I <kishon@ti.com> - 2015-08-05 16:10 +0200

csiph-web