Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1200108

Re: [PATCH 5/8] watchdog: imx2: Convert to use infrastructure triggered keepalives

From Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH 5/8] watchdog: imx2: Convert to use infrastructure triggered keepalives
Date 2015-08-04 17:50 +0200
Message-ID <pTMDv-6sx-11@gated-at.bofh.it> (permalink)
References <pTzZD-57V-3@gated-at.bofh.it> <pTzZE-57V-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello,

On Mon, Aug 03, 2015 at 07:13:31PM -0700, Guenter Roeck wrote:
> The watchdog infrastructure now supports handling watchdog keepalive
> if the watchdog is running while the watchdog device is closed.
> Convert the driver to use this infrastructure.
> 
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/watchdog/imx2_wdt.c | 72 ++++++++-------------------------------------

I tested the series on an i.MX27 machine and it works nicely. When the
watchdog is already running at probe time it is constantly pinged until
userspace opens /dev/watchdog. With the patch I sent earlier today the
functionallity is also given, that is the machine resets iff I stop
pinging. And when I do a stopping-close the worker looks for this in
hardware non-stoppable device.

Very nice, and also \o/ for the diffstat,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 5/8] watchdog: imx2: Convert to use infrastructure triggered keepalives Guenter Roeck <linux@roeck-us.net> - 2015-08-04 04:20 +0200
  Re: [PATCH 5/8] watchdog: imx2: Convert to use infrastructure  triggered keepalives Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2015-08-04 17:50 +0200

csiph-web