Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1199984

Re: [PATCH 1/3] cgroup: define controller file conventions

Show all headers | View raw

Hello, Peter.

On Tue, Aug 04, 2015 at 10:48:55AM +0200, Peter Zijlstra wrote:
> > +- If a controller implements ratio based resource distribution, the
> > +  control knob should be named "weight" and have the range [1, 10000]
> > +  and 100 should be the default value.  The values are chosen to allow
> > +  enough and symmetric bias in both directions while keeping it
> > +  intuitive (the default is 100%).
> 
> Aside from 100% being a sane 'default', what it actually is is a unit.
> 100% == 1.
> 
> So I would suggest naming the thing CGROUP_WEIGHT_UNIT := 100,

It's a minor point either way but I think people would generally find
default more familiar.

> > +/*
> > + * All weight knobs on the default hierarhcy should use the following min,
> > + * default and max values.  The default value is the logarithmic center of
> > + * MIN and MAX and allows 100x to be expressed in both directions.
> > + */
> > +#define CGROUP_WEIGHT_MIN		1
> > +#define CGROUP_WEIGHT_DFL		100
> > +#define CGROUP_WEIGHT_MAX		10000
> 
> That said, I'm not entirely keen on having to change this.

Yeah, changing the scale is an icky thing to do but I think the
benefits of unifying the scales across different controllers outweigh
here.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCHSET sched,cgroup] sched: Implement interface for cgroup unified hierarchy Tejun Heo <tj@kernel.org> - 2015-08-04 00:50 +0200
  [PATCH 3/3] sched: Implement interface for cgroup unified hierarchy Tejun Heo <tj@kernel.org> - 2015-08-04 00:50 +0200
    Re: [PATCH 3/3] sched: Implement interface for cgroup unified  hierarchy Peter Zijlstra <peterz@infradead.org> - 2015-08-04 11:10 +0200
      Re: [PATCH 3/3] sched: Implement interface for cgroup unified  hierarchy Tejun Heo <tj@kernel.org> - 2015-08-04 17:20 +0200
        Re: [PATCH 3/3] sched: Implement interface for cgroup unified  hierarchy Peter Zijlstra <peterz@infradead.org> - 2015-08-05 11:20 +0200
          Re: [PATCH 3/3] sched: Implement interface for cgroup unified  hierarchy Tejun Heo <tj@kernel.org> - 2015-08-05 16:40 +0200
            Re: [PATCH 3/3] sched: Implement interface for cgroup unified  hierarchy Tejun Heo <tj@kernel.org> - 2015-08-17 22:40 +0200
            Re: [PATCH 3/3] sched: Implement interface for cgroup unified hierarchy Paul Turner <pjt@google.com> - 2015-08-18 06:10 +0200
              Re: [PATCH 3/3] sched: Implement interface for cgroup unified  hierarchy Tejun Heo <tj@kernel.org> - 2015-08-18 22:40 +0200
                Re: [PATCH 3/3] sched: Implement interface for cgroup unified  hierarchy Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> - 2015-08-19 01:50 +0200
                Re: [PATCH 3/3] sched: Implement interface for cgroup unified  hierarchy Tejun Heo <tj@kernel.org> - 2015-08-19 18:30 +0200
                Re: [PATCH 3/3] sched: Implement interface for cgroup unified  hierarchy Mike Galbraith <umgwanakikbuti@gmail.com> - 2015-08-19 05:30 +0200
                Re: [PATCH 3/3] sched: Implement interface for cgroup unified  hierarchy Tejun Heo <tj@kernel.org> - 2015-08-19 18:50 +0200
    [PATCH v2 3/3] sched: Implement interface for cgroup unified  hierarchy Tejun Heo <tj@kernel.org> - 2015-08-04 21:40 +0200
  [PATCH 1/3] cgroup: define controller file conventions Tejun Heo <tj@kernel.org> - 2015-08-04 00:50 +0200
    Re: [PATCH 1/3] cgroup: define controller file conventions Peter Zijlstra <peterz@infradead.org> - 2015-08-04 10:50 +0200
      Re: [PATCH 1/3] cgroup: define controller file conventions Tejun Heo <tj@kernel.org> - 2015-08-04 17:00 +0200
    Re: [PATCH 1/3] cgroup: define controller file conventions Peter Zijlstra <peterz@infradead.org> - 2015-08-04 10:50 +0200
      Re: [PATCH 1/3] cgroup: define controller file conventions Tejun Heo <tj@kernel.org> - 2015-08-04 17:00 +0200
    [PATCH v2 1/3] cgroup: define controller file conventions Tejun Heo <tj@kernel.org> - 2015-08-04 21:40 +0200
      Re: [PATCH v2 1/3] cgroup: define controller file conventions Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> - 2015-08-05 03:00 +0200
        Re: [PATCH v2 1/3] cgroup: define controller file conventions Michal Hocko <mhocko@kernel.org> - 2015-08-05 09:50 +0200
          Re: [PATCH v2 1/3] cgroup: define controller file conventions Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> - 2015-08-06 04:40 +0200
            Re: [PATCH v2 1/3] cgroup: define controller file conventions Michal Hocko <mhocko@kernel.org> - 2015-08-07 20:20 +0200
              Re: [PATCH v2 1/3] cgroup: define controller file conventions Johannes Weiner <hannes@cmpxchg.org> - 2015-08-18 00:10 +0200
      Re: [PATCH v2 1/3] cgroup: define controller file conventions Johannes Weiner <hannes@cmpxchg.org> - 2015-08-17 23:40 +0200
  [PATCH 2/3] sched: Misc preps for cgroup unified hierarchy interface Tejun Heo <tj@kernel.org> - 2015-08-04 00:50 +0200

csiph-web