Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1199820

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

Show all headers | View raw

On Tue, Aug 04, 2015 at 11:30:36AM +0200, Paul Bolle wrote:
> On ma, 2015-08-03 at 16:56 -0400, Matt Porter wrote:
> > --- /dev/null
> > +++ b/drivers/iio/temperature/max6675.c
> > +static const struct spi_device_id max6675_spi_ids[] = {
> > +	{"max6675", 0},
> > +	{},
> > +};
> > +MODULE_DEVICE_TABLE(spi, max6675_spi_ids);
> 
> > +MODULE_ALIAS("spi:max6675");
> 
> For the "spi" alias this is "belt and suspenders":
>     modinfo ./max6675.ko | grep alias
>     alias:          spi:max6675
>     alias:          acpi*:MXIM6675:*
>     alias:          of:N*T*Cmaxim,max6675*
>     alias:          spi:max6675
> 
> I'd drop the MODULE_ALIAS().

Ok, given that it generates a redundant alias I'll drop it.

> (Mark Brown made it quite clear I shouldn't nag people about the origin
> of the various strings used in these module aliases. So I won't. But if
> you'd volunteer to explain me where "max6675" might come from for the
> spi alias that would, at least, satisfy my curiosity.)

Sure, one might hotplug in an entire SPI master and this SPI slave device
via any discoverable bus and need the alias to match the module. It's
also typically used in a board file on embedded x86 stuff where overriding
the DSDT is not desirable.

-Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] MAX6675 IIO temperature driver Matt Porter <mporter@konsulko.com> - 2015-08-03 23:00 +0200
  [PATCH 1/3] iio: temperature: add max6675 dt binding Matt Porter <mporter@konsulko.com> - 2015-08-03 23:00 +0200
  [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver Matt Porter <mporter@konsulko.com> - 2015-08-03 23:00 +0200
    Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter  driver Peter Meerwald <pmeerw@pmeerw.net> - 2015-08-03 23:30 +0200
      Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter  driver Matt Porter <mporter@konsulko.com> - 2015-08-04 01:20 +0200
      Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter  driver Matt Porter <mporter@konsulko.com> - 2015-08-06 19:40 +0200
        Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter  driver Jonathan Cameron <jic23@kernel.org> - 2015-08-08 13:40 +0200
    Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver Matt Ranostay <mranostay@gmail.com> - 2015-08-04 00:40 +0200
      Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter  driver Matt Porter <mporter@konsulko.com> - 2015-08-04 01:20 +0200
    Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver Daniel Baluta <daniel.baluta@intel.com> - 2015-08-04 10:00 +0200
      Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter  driver Matt Porter <mporter@konsulko.com> - 2015-08-04 15:10 +0200
    Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple  converter driver Paul Bolle <pebolle@tiscali.nl> - 2015-08-04 11:40 +0200
      Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter  driver Matt Porter <mporter@konsulko.com> - 2015-08-04 15:20 +0200
  Re: [PATCH 0/3] MAX6675 IIO temperature driver Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2015-08-04 19:00 +0200
    Re: [PATCH 0/3] MAX6675 IIO temperature driver Matt Porter <mporter@konsulko.com> - 2015-08-04 19:40 +0200
      Re: [PATCH 0/3] MAX6675 IIO temperature driver Daniel Baluta <daniel.baluta@gmail.com> - 2015-08-05 10:40 +0200
        Re: [PATCH 0/3] MAX6675 IIO temperature driver Matt Porter <mporter@konsulko.com> - 2015-08-05 13:50 +0200
      Re: [PATCH 0/3] MAX6675 IIO temperature driver Jonathan Cameron <jic23@kernel.org> - 2015-08-08 13:40 +0200

csiph-web