Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1199847

Re: [PATCH v3] HID: hid-input: Fix accessing freed memory during device disconnect

Show all headers | View raw

On Mon, 3 Aug 2015, Krzysztof Kozlowski wrote:

> During unbinding the driver was dereferencing a pointer to memory
> already freed by power_supply_unregister().
> 
> Driver was freeing its internal description of battery through pointers
> stored in power_supply structure. However, because the core owns the
> power supply instance, after calling power_supply_unregister() this
> memory is freed and the driver cannot access these members.
> 
> Fix this by storing the pointer to internal description of battery in a
> local variable before calling power_supply_unregister(), so the pointer
> remains valid.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reported-by: H.J. Lu <hjl.tools@gmail.com>
> Fixes: 297d716f6260 ("power_supply: Change ownership from driver to core")
> Cc: <stable@vger.kernel.org>

Applied to for-4.2/upstream-fixes-devm-fixed, and thanks again Dmitry for 
catching my mistake.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] HID: hid-input: Fix accessing freed memory during device  disconnect Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-08-03 08:00 +0200
  Re: [PATCH v3] HID: hid-input: Fix accessing freed memory during  device disconnect Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-08-03 22:40 +0200
  Re: [PATCH v3] HID: hid-input: Fix accessing freed memory during  device disconnect Jiri Kosina <jkosina@suse.com> - 2015-08-04 15:50 +0200

csiph-web