Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1199844

Re: kdbus: to merge or not to merge?

From Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups linux.kernel
Subject Re: kdbus: to merge or not to merge?
Date 2015-08-04 15:50 +0200
Message-ID <pTKLo-3IO-19@gated-at.bofh.it> (permalink)
References <pEpzc-2uw-1@gated-at.bofh.it> <pTx1M-Kt-13@gated-at.bofh.it> <pTGeM-5Af-47@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Aug 4, 2015 at 1:58 AM, David Herrmann <dh.herrmann@gmail.com> wrote:
>
> You lack a call to sd_bus_unref() here.

I assume it was intentional. Why would Andy talk about "scaling" otherwise?

And the worry was why the kdbus version killed the machine, but the
userspace version did not. That's a rather big difference, and not a
good one.

Possibly the kdbus version ends up not just allocating user space
memory (which we should handle gracefully), but kernel allocations too
(which absolutely have to be explicitly resource-managed).

               Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: kdbus: to merge or not to merge? Andy Lutomirski <luto@kernel.org> - 2015-08-04 01:10 +0200
  Re: kdbus: to merge or not to merge? David Herrmann <dh.herrmann@gmail.com> - 2015-08-04 11:00 +0200
    Re: kdbus: to merge or not to merge? Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-04 15:50 +0200
      Re: kdbus: to merge or not to merge? David Herrmann <dh.herrmann@gmail.com> - 2015-08-04 16:20 +0200
        Re: kdbus: to merge or not to merge? Andy Lutomirski <luto@amacapital.net> - 2015-08-04 16:50 +0200
          Re: kdbus: to merge or not to merge? Andy Lutomirski <luto@amacapital.net> - 2015-08-05 02:20 +0200
            Re: kdbus: to merge or not to merge? Daniel Mack <daniel@zonque.org> - 2015-08-06 09:10 +0200
              Re: kdbus: to merge or not to merge? Andy Lutomirski <luto@amacapital.net> - 2015-08-06 17:30 +0200
                Re: kdbus: to merge or not to merge? Daniel Mack <daniel@zonque.org> - 2015-08-06 19:30 +0200
          Re: kdbus: to merge or not to merge? David Herrmann <dh.herrmann@gmail.com> - 2015-08-05 09:20 +0200
            Re: kdbus: to merge or not to merge? Andy Lutomirski <luto@amacapital.net> - 2015-08-05 22:20 +0200
              Re: kdbus: to merge or not to merge? David Herrmann <dh.herrmann@gmail.com> - 2015-08-06 10:10 +0200
                Re: kdbus: to merge or not to merge? Martin Steigerwald <martin@lichtvoll.de> - 2015-08-06 10:30 +0200
                Re: kdbus: to merge or not to merge? Andy Lutomirski <luto@amacapital.net> - 2015-08-06 17:30 +0200
                Re: kdbus: to merge or not to merge? Daniel Mack <daniel@zonque.org> - 2015-08-06 20:20 +0200
                Re: kdbus: to merge or not to merge? Andy Lutomirski <luto@amacapital.net> - 2015-08-06 20:50 +0200
                Re: kdbus: to merge or not to merge? Daniel Mack <daniel@zonque.org> - 2015-08-07 16:50 +0200
                Re: kdbus: to merge or not to merge? Andy Lutomirski <luto@amacapital.net> - 2015-08-07 17:10 +0200
                Re: kdbus: to merge or not to merge? Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-08-09 21:10 +0200
                Re: kdbus: to merge or not to merge? Daniel Mack <daniel@zonque.org> - 2015-08-10 00:20 +0200
                Re: kdbus: to merge or not to merge? Andy Lutomirski <luto@amacapital.net> - 2015-08-10 04:20 +0200
                Re: kdbus: to merge or not to merge? Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-10 19:10 +0200
                Re: kdbus: to merge or not to merge? David Lang <david@lang.hm> - 2015-08-10 04:50 +0200
                Re: kdbus: to merge or not to merge? cee1 <fykcee1@gmail.com> - 2015-08-07 17:40 +0200

csiph-web