Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1199766

Re: [PATCH 4/9] usb: host: ehci-st: Simplify return statement

Show all headers | View raw

Hi

On 08/04/2015 11:10 AM, Karajgaonkar, Saurabh (S.) wrote:
> From: Saurabh Karajgaonkar <skarajga@visteon.com>
>
> Replace redundant variable use in return statement.
>
> Signed-off-by: Saurabh Karajgaonkar <skarajga@visteon.com>
> ---
>   drivers/usb/host/ehci-st.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c
> index 7e4bd39..b7c5cfa 100644
> --- a/drivers/usb/host/ehci-st.c
> +++ b/drivers/usb/host/ehci-st.c
> @@ -54,7 +54,6 @@ static int st_ehci_platform_reset(struct usb_hcd *hcd)
>   	struct platform_device *pdev = to_platform_device(hcd->self.controller);
>   	struct usb_ehci_pdata *pdata = dev_get_platdata(&pdev->dev);
>   	struct ehci_hcd *ehci = hcd_to_ehci(hcd);
> -	int retval;
>   	u32 threshold;
>   
>   	/* Set EHCI packet buffer IN/OUT threshold to 128 bytes */
> @@ -62,11 +61,7 @@ static int st_ehci_platform_reset(struct usb_hcd *hcd)
>   	writel(threshold, hcd->regs + AHB2STBUS_INSREG01);
>   
>   	ehci->caps = hcd->regs + pdata->caps_offset;
> -	retval = ehci_setup(hcd);
> -	if (retval)
> -		return retval;
> -
> -	return 0;
> +	return ehci_setup(hcd);
>   }
>   
>   static int st_ehci_platform_power_on(struct platform_device *dev)


Acked-by: Patrice Chotard <patrice.chotard@st.com>

Thanks

Patrice
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/9] usb: host: ehci-st: Simplify return statement "Karajgaonkar, Saurabh (S.)" <skarajga@visteon.com> - 2015-08-04 11:30 +0200
  Re: [PATCH 4/9] usb: host: ehci-st: Simplify return statement Patrice Chotard <patrice.chotard@st.com> - 2015-08-04 14:30 +0200

csiph-web