Groups > linux.kernel > #1199634

Re: [PATCH net] virtio-net: drop NETIF_F_FRAGLIST

From	"Michael S. Tsirkin" <mst@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net] virtio-net: drop NETIF_F_FRAGLIST
Date	2015-08-04 12:10 +0200
Message-ID	<pTHkt-7nj-3@gated-at.bofh.it> (permalink)
References	<pTHaO-6WK-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 04, 2015 at 05:55:45PM +0800, Jason Wang wrote:
> virtio declares support for NETIF_F_FRAGLIST, but assumes
> that there are at most MAX_SKB_FRAGS + 2 fragments which isn't
> always true with a fraglist.
> 
> A longer fraglist in the skb will make the call to skb_to_sgvec overflow
> the sg array, leading to memory corruption.
> 
> Drop NETIF_F_FRAGLIST so we only get what we can handle.
> 
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Jason Wang <jasowang@redhat.com>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

Especially important now that virtio_net: add gro capability
was merged for net-next, making bridged setups create fraglists.

> ---
> The patch is needed for stable.
> ---
>  drivers/net/virtio_net.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 7fbca37..2347a73 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1756,9 +1756,9 @@ static int virtnet_probe(struct virtio_device *vdev)
>  	/* Do we support "hardware" checksums? */
>  	if (virtio_has_feature(vdev, VIRTIO_NET_F_CSUM)) {
>  		/* This opens up the world of extra features. */
> -		dev->hw_features |= NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST;
> +		dev->hw_features |= NETIF_F_HW_CSUM|NETIF_F_SG;
>  		if (csum)
> -			dev->features |= NETIF_F_HW_CSUM|NETIF_F_SG|NETIF_F_FRAGLIST;
> +			dev->features |= NETIF_F_HW_CSUM|NETIF_F_SG;
>  
>  		if (virtio_has_feature(vdev, VIRTIO_NET_F_GSO)) {
>  			dev->hw_features |= NETIF_F_TSO | NETIF_F_UFO
> -- 
> 2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH net] virtio-net: drop NETIF_F_FRAGLIST Jason Wang <jasowang@redhat.com> - 2015-08-04 12:00 +0200
  Re: [PATCH net] virtio-net: drop NETIF_F_FRAGLIST "Michael S. Tsirkin" <mst@redhat.com> - 2015-08-04 12:10 +0200
  Re: [PATCH net] virtio-net: drop NETIF_F_FRAGLIST Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-08-04 13:20 +0200
    Re: [PATCH net] virtio-net: drop NETIF_F_FRAGLIST Jason Wang <jasowang@redhat.com> - 2015-08-05 04:40 +0200

csiph-web