Groups > linux.kernel > #1199576

Re: [RFC PATCH 2/3] mailbox: Hisilicon: add mailbox driver

From	Leo Yan <leo.yan@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 2/3] mailbox: Hisilicon: add mailbox driver
Date	2015-08-04 11:10 +0200
Message-ID	<pTGop-60Z-9@gated-at.bofh.it> (permalink)
References	<pTcA1-4np-11@gated-at.bofh.it> <pTcA1-4np-9@gated-at.bofh.it> <pTFVo-5cP-17@gated-at.bofh.it> <pTG53-5oC-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Paul,

On Tue, Aug 04, 2015 at 04:49:30PM +0800, Leo Yan wrote:
> On Tue, Aug 04, 2015 at 10:30:24AM +0200, Paul Bolle wrote:
> > (This RFC was part of this mornings catch of my crude mail filter. So,
> > for what it's worth, what follows are a few random comments for the few
> > things I'm able to spot.)

[...]

> > > +static int __init hi6220_mbox_init(void)
> > > +{
> > > +	return platform_driver_register(&hi6220_mbox_driver);
> > > +}
> > > +module_init(hi6220_mbox_init);
> > > +
> > > +static void __exit hi6220_mbox_exit(void)
> > > +{
> > > +	platform_driver_unregister(&hi6220_mbox_driver);
> > > +}
> > > +module_exit(hi6220_mbox_exit);
> > 
> > This could be flattened into one line:
> >     module_platform_driver(hi6220_mbox_driver);

Need clarify one thing: will modify to use core_initcall() for driver's
initialization; due another clock driver depends on this mailbox driver,
so mailbox init firstly with core_initcall() and use subsys_initcall()
for clock driver.

Thanks,
Leo Yan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[RFC PATCH 0/3] mailbox: hisilicon: add mailbox driver Leo Yan <leo.yan@linaro.org> - 2015-08-03 03:20 +0200
  [RFC PATCH 3/3] arm64: dts: add Hi6220 mailbox node Leo Yan <leo.yan@linaro.org> - 2015-08-03 03:20 +0200
  [RFC PATCH 2/3] mailbox: Hisilicon: add mailbox driver Leo Yan <leo.yan@linaro.org> - 2015-08-03 03:20 +0200
    Re: [RFC PATCH 2/3] mailbox: Hisilicon: add mailbox driver Paul Bolle <pebolle@tiscali.nl> - 2015-08-04 10:40 +0200
      Re: [RFC PATCH 2/3] mailbox: Hisilicon: add mailbox driver Leo Yan <leo.yan@linaro.org> - 2015-08-04 10:50 +0200
        Re: [RFC PATCH 2/3] mailbox: Hisilicon: add mailbox driver Leo Yan <leo.yan@linaro.org> - 2015-08-04 11:10 +0200
        Re: [RFC PATCH 2/3] mailbox: Hisilicon: add mailbox driver Paul Bolle <pebolle@tiscali.nl> - 2015-08-04 11:20 +0200
          Re: [RFC PATCH 2/3] mailbox: Hisilicon: add mailbox driver Leo Yan <leo.yan@linaro.org> - 2015-08-04 12:00 +0200
  [RFC PATCH 1/3] dt-bindings: mailbox: Document Hisilicon mailbox driver Leo Yan <leo.yan@linaro.org> - 2015-08-03 03:20 +0200
  Re: [RFC PATCH 0/3] mailbox: hisilicon: add mailbox driver Jassi Brar <jassisinghbrar@gmail.com> - 2015-08-05 13:00 +0200
    Re: [RFC PATCH 0/3] mailbox: hisilicon: add mailbox driver Leo Yan <leo.yan@linaro.org> - 2015-08-06 01:20 +0200
      Re: [RFC PATCH 0/3] mailbox: hisilicon: add mailbox driver Jassi Brar <jassisinghbrar@gmail.com> - 2015-08-10 09:10 +0200
        Re: [RFC PATCH 0/3] mailbox: hisilicon: add mailbox driver Leo Yan <leo.yan@linaro.org> - 2015-08-10 11:00 +0200

csiph-web