Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1199432

Re: [PATCH] net: dsa: fix EDSA frame from hwaccel frame

Show all headers | View raw

Hi David,

On Aug 4, 2015, at 1:21 AM, David davem@davemloft.net wrote:

> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> Date: Sun,  2 Aug 2015 21:46:02 -0400
> 
>> If the underlying network device features NETIF_F_HW_VLAN_CTAG_TX,
>> an EDSA frame is prepended with a 802.1q header once queued.
>> 
>> To fix this, push the VLAN tag to the payload if present, before
>> checking the frame protocol.
>> 
>> [note: we may prefer to access directly VLAN TCI from hwaccel frames,
>> but this approach is simpler.]
>> 
>> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> 
> This is a bug fix so should target 'net', but you generated the patch
> against 'net-next'.
> 
> In any event, you should be explicit about the tree you are targetting
> in order to not waste my time like this, by simply specifying the
> tree in your "[PATCH xxx]" text in your subject line.   Either
> "[PATCH net]" or "[PATCH net-next]".

Dully noted. Should I resend it?

Thanks,
-v
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: dsa: fix EDSA frame from hwaccel frame Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-08-03 03:50 +0200
  Re: [PATCH] net: dsa: fix EDSA frame from hwaccel frame David Miller <davem@davemloft.net> - 2015-08-04 07:30 +0200
    Re: [PATCH] net: dsa: fix EDSA frame from hwaccel frame Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2015-08-04 08:10 +0200
      Re: [PATCH] net: dsa: fix EDSA frame from hwaccel frame David Miller <davem@davemloft.net> - 2015-08-04 08:30 +0200

csiph-web