Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1199410

Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG

Show all headers | View raw

From: Joe Perches <joe@perches.com>
Date: Mon, 03 Aug 2015 21:02:21 -0700

> On Mon, 2015-08-03 at 20:57 -0700, Joe Perches wrote:
>> On Tue, 2015-08-04 at 05:26 +0200, Jason A. Donenfeld wrote:
>> > This patch replaces calls to net_dbg_ratelimited when !DEBUG with
>> > no_printk, keeping with the idiom of all the other debug print helpers.
>> 
>> Makes sense, thanks Jason.
> 
> Perhaps better still would be to use if (0) no_printk so that
> the call and whatever argument calls the net_dbg_ratelimited
> makes are completely eliminated.

Agreed. Jason please respin your patch to work this way.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG "Jason A. Donenfeld" <Jason@zx2c4.com> - 2015-08-04 05:30 +0200
  Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG Joe Perches <joe@perches.com> - 2015-08-04 06:00 +0200
    Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG Joe Perches <joe@perches.com> - 2015-08-04 06:10 +0200
      Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG David Miller <davem@davemloft.net> - 2015-08-04 07:00 +0200
        Re: [PATCH] net_dbg_ratelimited: turn into no-op when !DEBUG "Jason A. Donenfeld" <Jason@zx2c4.com> - 2015-08-04 17:10 +0200

csiph-web