Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1199407
| From | Rusty Russell <rusty@rustcorp.com.au> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch 2/7] x86/lguest: Do not setup unused irq vectors |
| Date | 2015-08-04 06:40 +0200 |
| Message-ID | <pTCb8-8cq-1@gated-at.bofh.it> (permalink) |
| References | <pT8d3-6tx-3@gated-at.bofh.it> <pT8d3-6tx-11@gated-at.bofh.it> <pTe8N-6yq-3@gated-at.bofh.it> <pTkxA-7HQ-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Thomas Gleixner <tglx@linutronix.de> writes: > On Mon, 3 Aug 2015, Rusty Russell wrote: >> Thomas Gleixner <tglx@linutronix.de> writes: >> > + >> > + /* Some systems map "vectors" to interrupts weirdly. Not us! */ >> > + __this_cpu_write(vector_irq[FIRST_EXTERNAL_VECTOR + irq, irq); >> >> Missing ]. > > Doh. > >> [ 17.751889] do_IRQ: 0.33 No irq handler for vector (irq -1) >> >> You broke interrupts :( > > Right, because I missed the other place which fiddles with > interrupts. Does the patch below fix the issue? Yep. I added error handling. I reworked it into two patches: one which staticizes lguest_setup_irq() and moves it up, the other of which applies your changes. Will post, you can take them... Thanks, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch 2/7] x86/lguest: Do not setup unused irq vectors Thomas Gleixner <tglx@linutronix.de> - 2015-08-02 22:40 +0200
Re: [patch 2/7] x86/lguest: Do not setup unused irq vectors Rusty Russell <rusty@rustcorp.com.au> - 2015-08-03 05:00 +0200
Re: [patch 2/7] x86/lguest: Do not setup unused irq vectors Thomas Gleixner <tglx@linutronix.de> - 2015-08-03 11:50 +0200
Re: [patch 2/7] x86/lguest: Do not setup unused irq vectors Rusty Russell <rusty@rustcorp.com.au> - 2015-08-04 06:40 +0200
[PATCH 2/2] x86/lguest: Do not setup unused irq vectors Rusty Russell <rusty@rustcorp.com.au> - 2015-08-04 06:40 +0200
[PATCH 1/2] x86/lguest: clean up lguest_setup_irq. Rusty Russell <rusty@rustcorp.com.au> - 2015-08-04 06:40 +0200
csiph-web