Groups > linux.kernel > #1199386

Re: [PATCH 00/15] trivial: Drop unlikely before IS_ERR(_OR_NULL)

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 00/15] trivial: Drop unlikely before IS_ERR(_OR_NULL)
Date	2015-08-04 04:30 +0200
Message-ID	<pTA9j-5jk-5@gated-at.bofh.it> (permalink)
References	<pSe1b-aE-3@gated-at.bofh.it> <pSf6W-1KB-31@gated-at.bofh.it> <pSfJD-2JP-7@gated-at.bofh.it> <pTvCF-6Zh-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 03-08-15, 17:38, Steven Rostedt wrote:
> On Fri, 31 Jul 2015 13:23:10 +0300
> "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
> > We have two cases in code:
> > 
> > drivers/rtc/rtc-gemini.c:       if (likely(IS_ERR(rtc->rtc_dev)))
> > drivers/staging/lustre/lustre/obdclass/lu_object.c:     if (likely(IS_ERR(shadow) && PTR_ERR(shadow) == -ENOENT)) {
> > 
> > The first one is mistake, I think. Or do we expect rtc_device_register()
> > to fail?
> > 
> > The second is redundant. "if (PTR_ERR(shadow) == -ENOENT)" should do the
> > job.
> > 
> 
> Yep, those look like bugs to me.

Yeah, I have fixed both of them :)

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 00/15] trivial: Drop unlikely before IS_ERR(_OR_NULL) Steven Rostedt <rostedt@goodmis.org> - 2015-08-03 23:40 +0200
  Re: [PATCH 00/15] trivial: Drop unlikely before IS_ERR(_OR_NULL) Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-04 04:30 +0200

csiph-web