Groups > linux.kernel > #1198441

Re: [PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller

From	Noralf Trønnes <noralf@tronnes.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller
Date	2015-08-02 20:00 +0200
Message-ID	<pT5Ie-2NJ-23@gated-at.bofh.it> (permalink)
References	<pPmxY-4SX-11@gated-at.bofh.it> <pT2U2-7aY-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Den 02.08.2015 16:57, skrev Fabio Falzoi:
> Use a struct flexfb_lcd_controller to holds chip properties, instead of
> relying on a long 'if - else if' chain.
> This allows to:
> - use a simple linear search to verify if a certain LCD controller
> model is supported or not.
> - add support for a new LCD chip controller simply defining a new
> flexfb_lcd_controller struct.
>
> Signed-off-by: Fabio Falzoi <fabio.falzoi84@gmail.com>
> Acked-by: Noralf Trønnes <noralf@tronnes.org>
> ---

Seems I wasn't clear enough, you could use my ack if you put
struct flexfb_lcd_controller inside the driver and not in
fbtft.h


Noralf.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] Staging: fbtft: Use a struct to describe each LCD controller Fabio Falzoi <fabio.falzoi84@gmail.com> - 2015-08-02 17:00 +0200
  Re: [PATCH v2] Staging: fbtft: Use a struct to describe each LCD  controller Noralf Trønnes <noralf@tronnes.org> - 2015-08-02 20:00 +0200

csiph-web