Groups > linux.kernel > #1198433

Re: [PATCH] x86: serialize LVTT and TSC_DEADLINE write

From	Shaohua Li <shli@fb.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86: serialize LVTT and TSC_DEADLINE write
Date	2015-08-02 18:00 +0200
Message-ID	<pT3Q6-59-11@gated-at.bofh.it> (permalink)
References	<pSqOJ-2jd-7@gated-at.bofh.it> <pSC3v-1Jd-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Aug 01, 2015 at 12:10:41PM +0200, Thomas Gleixner wrote:
> On Fri, 31 Jul 2015, Shaohua Li wrote:
> > @@ -336,6 +336,22 @@ static void __setup_APIC_LVTT(unsigned int clocks, int oneshot, int irqen)
> >  	apic_write(APIC_LVTT, lvtt_value);
> >  
> >  	if (lvtt_value & APIC_LVT_TIMER_TSCDEADLINE) {
> > +		u64 msr;
> > +
> > +		/*
> > +		 * See Intel SDM: TSC-Deadline Mode chapter. In xAPIC mode,
> > +		 * writing APIC LVTT and TSC_DEADLINE MSR isn't serialized.
> > +		 * This uses the algorithm described in Intel SDM to serialize
> > +		 * the two writes
> > +		 * */
> > +		while (1) {
> > +			wrmsrl(MSR_IA32_TSC_DEADLINE, -1L);
> > +			rdmsrl(MSR_IA32_TSC_DEADLINE, msr);
> > +			if (msr)
> > +				break;
> > +		}
> > +		wrmsrl(MSR_IA32_TSC_DEADLINE, 0);
> 
> 
> I think this is exceptionally silly. A proper fence after the
> apic_write() should have the same effect.

Not sure what happens in the hardware, I could have a try of fence, but
I'd prefer using the algorithm Intel described. This is not a fast path,
the loop will exit immediately regardless the issue occurs anyway.

Thanks,
Shaohua
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] x86: serialize LVTT and TSC_DEADLINE write Thomas Gleixner <tglx@linutronix.de> - 2015-08-01 12:20 +0200
  Re: [PATCH] x86: serialize LVTT and TSC_DEADLINE write Thomas Gleixner <tglx@linutronix.de> - 2015-08-02 21:50 +0200
    Re: [PATCH] x86: serialize LVTT and TSC_DEADLINE write Shaohua Li <shli@fb.com> - 2015-08-04 02:00 +0200
  Re: [PATCH] x86: serialize LVTT and TSC_DEADLINE write Shaohua Li <shli@fb.com> - 2015-08-02 18:00 +0200

csiph-web