Groups > linux.kernel > #1197892

[RFC] alpha: use asm-generic/io.h

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	"Luis R. Rodriguez" <mcgrof@do-not-panic.com>
Newsgroups	linux.kernel
Subject	[RFC] alpha: use asm-generic/io.h
Date	Sat, 01 Aug 2015 02:40:02 +0200
Message-ID	<pSt0e-5mM-9@gated-at.bofh.it> (permalink)
X-Original-To	rth@twiddle.net
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=XKxlf+Z6EKdb2PAEDcZMFuQ4SP72xR70Gu0sjoCkAdM=; b=vN5lGbDxdQzpfJcZAINAOohlTygUkqKNDz22P0aMzyWhnda7etD275X2dEJcKZXX8E gbHZRM0Ghe926BJJIKqodHk4Lt2pdTvjhrD6hltys0LG9mJ9kz3EH/TFh+HffwcNC+MO 02A1z6XM8V1BaQsVnkB6qkfBeHVoRJvuqnlZY8UZkxM/NnHtJmWhOTnQGCM0eUCDjDKc 2ASoLHaplpRuFYTSwy5Hj8mA1XcUeS+u1GC7GXH4PsZAIBnOll9Su5KIFtPloVzKeav+ zaNcJERjwRh0jhsB4AyannaYgw7XaLUrTCh5FG9MHGMTOdjIXBknVO2n+yZlINHwlEOi bMKg==
X-Received	by 10.69.1.7 with SMTP id bc7mr761103pbd.154.1438389516320; Fri, 31 Jul 2015 17:38:36 -0700 (PDT)
X-Mailer	git-send-email 2.1.4
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	50
Organization	linux.* mail to news gateway
X-Original-Cc	ink@jurassic.park.msu.ru, mattst88@gmail.com, will.deacon@arm.com, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux@roeck-us.net, paul.gortmaker@windriver.com, mingo@kernel.org, linux-next@vger.kernel.org, "Luis R. Rodriguez" <mcgrof@suse.com>
X-Original-Date	Fri, 31 Jul 2015 17:38:29 -0700
X-Original-Message-ID	<1438389509-16908-1-git-send-email-mcgrof@do-not-panic.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1197892

Show key headers only | View raw

From: "Luis R. Rodriguez" <mcgrof@suse.com>

Since alpha does not include asm-generic/io.h it would mean
alpha folks have to always carefully monitor asm-generic patches
and before they get merged make sure their own arch implementation
solution gets added. By using asm-generic/io.h alpha gets sensible
defaults, in this case ioremap_uc() would be one example, where
by default it would return NULL, so not implemented. When alpha
folks get a chance then they can add the appropriate
implementation.

Reported-by: Guenter Roeck <linux@roeck-us.net>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
---

The easy solution *for now* is to just do:

#define ioremap_uc ioremap_nocache

*But* that would have to be done for any other asm-generic/io.h collateral
evolution, this on the other hand, would get it right for alpha from the
get-go -- so I ask -- can this please be tested and if it is OK then consider
it be merged?

If we can't add asm-generic/io.h then the above define replacement would
be the way to go.

 arch/alpha/include/asm/io.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/alpha/include/asm/io.h b/arch/alpha/include/asm/io.h
index f05bdb4b1cb9..16a5bda42750 100644
--- a/arch/alpha/include/asm/io.h
+++ b/arch/alpha/include/asm/io.h
@@ -581,4 +581,6 @@ extern void outsl (unsigned long port, const void *src, unsigned long count);
 
 #endif /* __KERNEL__ */
 
+#include <asm-generic/io.h>
+
 #endif /* __ALPHA_IO_H */
-- 
2.3.2.209.gd67f9d5.dirty

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[RFC] alpha: use asm-generic/io.h "Luis R. Rodriguez" <mcgrof@do-not-panic.com> - 2015-08-01 02:40 +0200
  Re: [RFC] alpha: use asm-generic/io.h Guenter Roeck <linux@roeck-us.net> - 2015-08-01 03:10 +0200

csiph-web