Groups > linux.kernel > #1197171

Re: [PATCH 08/15] drivers: net: Drop unlikely before IS_ERR(_OR_NULL)

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 08/15] drivers: net: Drop unlikely before IS_ERR(_OR_NULL)
Date	2015-07-31 18:30 +0200
Message-ID	<pSlm3-2GV-33@gated-at.bofh.it> (permalink)
References	<pSe1b-aE-3@gated-at.bofh.it> <pSeaS-mJ-37@gated-at.bofh.it> <pSk6B-Yx-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 31-07-15, 11:04, Murali Karicheri wrote:
> On 07/31/2015 04:38 AM, Viresh Kumar wrote:
> >IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
> >is no need to do that again from its callers. Drop it.
> >
> 
> IS_ERR_OR_NULL() is defined as
> 
> static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr)
> {
>         return !ptr || IS_ERR_VALUE((unsigned long)ptr);
> }
> 
> So the unlikely() applies only to second part. Wouldn't that be a
> problem for optimization?

This is what the first patch of the series does:

http://permalink.gmane.org/gmane.linux.kernel/2009151

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 08/15] drivers: net: Drop unlikely before IS_ERR(_OR_NULL) Murali Karicheri <m-karicheri2@ti.com> - 2015-07-31 17:10 +0200
  RE: [PATCH 08/15] drivers: net: Drop unlikely before  IS_ERR(_OR_NULL) David Laight <David.Laight@ACULAB.COM> - 2015-07-31 18:30 +0200
  Re: [PATCH 08/15] drivers: net: Drop unlikely before IS_ERR(_OR_NULL) Viresh Kumar <viresh.kumar@linaro.org> - 2015-07-31 18:30 +0200
    Re: [PATCH 08/15] drivers: net: Drop unlikely before IS_ERR(_OR_NULL) Murali Karicheri <m-karicheri2@ti.com> - 2015-08-03 18:00 +0200

csiph-web