Groups > linux.kernel > #1197122

Re: [PATCH net-next 5/9] openvswitch: Add conntrack action

From	Hannes Frederic Sowa <hannes@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 5/9] openvswitch: Add conntrack action
Date	2015-07-31 17:30 +0200
Message-ID	<pSkq0-1ly-43@gated-at.bofh.it> (permalink)
References	<pS0AV-6aH-5@gated-at.bofh.it> <pS0AV-6aH-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2015-07-30 at 11:12 -0700, Joe Stringer wrote:
> +static void do_output(struct datapath *dp, struct sk_buff *skb, int
> out_port,
> +		      struct sw_flow_key *key)
>  {
>  	struct vport *vport = ovs_vport_rcu(dp, out_port);
>  
> -	if (likely(vport))
> -		ovs_vport_send(vport, skb);
> -	else
> +	if (likely(vport)) {
> +		unsigned int mru = OVS_CB(skb)->mru;
> +		struct dst_entry *orig_dst = dst_clone(skb_dst(skb));

I think you forgot to remove this?

Bye,
Hannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH net-next 5/9] openvswitch: Add conntrack action Hannes Frederic Sowa <hannes@redhat.com> - 2015-07-31 17:30 +0200

csiph-web