Groups > linux.kernel > #1197150

Re: [PATCH tip/core/rcu 19/19] rcu: Add fastpath bypassing funnel locking

From	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH tip/core/rcu 19/19] rcu: Add fastpath bypassing funnel locking
Date	2015-07-31 18:00 +0200
Message-ID	<pSkT0-1TL-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <pNneN-3lN-3@gated-at.bofh.it> <pNnot-3xc-3@gated-at.bofh.it> <pRXjI-1kU-7@gated-at.bofh.it> <pRY67-2v3-35@gated-at.bofh.it> <pRZ2b-3Qp-45@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jul 30, 2015 at 06:34:27PM +0200, Peter Zijlstra wrote:
> On Thu, Jul 30, 2015 at 08:34:52AM -0700, Paul E. McKenney wrote:
> > On Thu, Jul 30, 2015 at 04:44:55PM +0200, Peter Zijlstra wrote:
> 
> > > If the extra read before the cmpxchg() does not hurt, we should do the
> > > same for mutex and make the above redundant.
> > 
> > I am pretty sure that different hardware wants it done differently.  :-/
> 
> I think that most archs won't notice since any RmW includes a load of
> that variable anyhow. The only case where it can matter is if the RmW is
> done outside of the normal cache hierarchy -- like on Power, where the
> ll/sc bypasses the L1.

Some years back, AMD and Intel variants of x86 had different preferences
on this matter.  Timings indicated that one or the other of them (I
cannot recall which) would get the cacheline shared, then have to get
it exclusive, while the other would get it exclusive to begin with.

I honestly do not know what the preferences of current Power hardware
might be.

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH tip/core/rcu 19/19] rcu: Add fastpath bypassing funnel  locking Peter Zijlstra <peterz@infradead.org> - 2015-07-30 16:50 +0200
  Re: [PATCH tip/core/rcu 19/19] rcu: Add fastpath bypassing funnel  locking "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2015-07-30 17:40 +0200
    Re: [PATCH tip/core/rcu 19/19] rcu: Add fastpath bypassing funnel  locking Peter Zijlstra <peterz@infradead.org> - 2015-07-30 17:50 +0200
      Re: [PATCH tip/core/rcu 19/19] rcu: Add fastpath bypassing funnel  locking Steven Rostedt <rostedt@goodmis.org> - 2015-08-03 22:10 +0200
        Re: [PATCH tip/core/rcu 19/19] rcu: Add fastpath bypassing funnel  locking Peter Zijlstra <peterz@infradead.org> - 2015-08-03 22:10 +0200
    Re: [PATCH tip/core/rcu 19/19] rcu: Add fastpath bypassing funnel  locking "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2015-07-31 18:00 +0200

csiph-web