Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1197080

Re: [PATCHv9 28/36] mm, numa: skip PTE-mapped THP on numa fault

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 07/20/2015 04:21 PM, Kirill A. Shutemov wrote:
> We're going to have THP mapped with PTEs. It will confuse numabalancing.
> Let's skip them for now.

Fair enough.

Acked-by: Jerome Marchand <jmarchan@redhat.com>

> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Tested-by: Sasha Levin <sasha.levin@oracle.com>
> Tested-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> ---
>  mm/memory.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 074edab89b52..52f6fa02c099 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3186,6 +3186,12 @@ static int do_numa_page(struct mm_struct *mm, struct vm_area_struct *vma,
>  		return 0;
>  	}
>  
> +	/* TODO: handle PTE-mapped THP */
> +	if (PageCompound(page)) {
> +		pte_unmap_unlock(ptep, ptl);
> +		return 0;
> +	}
> +
>  	/*
>  	 * Avoid grouping on RO pages in general. RO pages shouldn't hurt as
>  	 * much anyway since they can be in shared cache state. This misses
> 

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCHv9 28/36] mm, numa: skip PTE-mapped THP on numa fault Jerome Marchand <jmarchan@redhat.com> - 2015-07-31 17:10 +0200

csiph-web