Groups > linux.kernel > #1198380

[PATCH] Fix logical-not-parentheses warning

From	Tomer Barletz <barletz@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] Fix logical-not-parentheses warning
Date	2015-08-02 11:10 +0200
Message-ID	<pSXrk-7Pm-9@gated-at.bofh.it> (permalink)
References	<pSVIR-5g5-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

This fixes the following warning, that is seen with gcc 5.1:
warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses].

Signed-off-by: Tomer Barletz <barletz@gmail.com>
---
 sound/pci/oxygen/oxygen_mixer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c
index 6492bca..4ca1266 100644
--- a/sound/pci/oxygen/oxygen_mixer.c
+++ b/sound/pci/oxygen/oxygen_mixer.c
@@ -88,7 +88,7 @@ static int dac_mute_put(struct snd_kcontrol *ctl,
 	int changed;
 
 	mutex_lock(&chip->mutex);
-	changed = !value->value.integer.value[0] != chip->dac_mute;
+	changed = (!value->value.integer.value[0]) != chip->dac_mute;
 	if (changed) {
 		chip->dac_mute = !value->value.integer.value[0];
 		chip->model.update_dac_mute(chip);
-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] Fix logical-not-parentheses warning Tomer Barletz <barletz@gmail.com> - 2015-08-02 11:10 +0200
  Re: [PATCH] Fix logical-not-parentheses warning Takashi Iwai <tiwai@suse.de> - 2015-08-03 10:20 +0200

csiph-web