Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1198425

Re: [PATCH v2 5/6] power: bq27xxx_battery: Add support for additional bq27xxx family devices

From Pavel Machek <pavel@ucw.cz>
Newsgroups linux.kernel
Subject Re: [PATCH v2 5/6] power: bq27xxx_battery: Add support for additional bq27xxx family devices
Date 2015-08-02 09:40 +0200
Message-ID <pSW2f-5CG-25@gated-at.bofh.it> (permalink)
References <pRiTg-1Zj-17@gated-at.bofh.it> <pRj2W-2aU-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> +#define INVALID_REG_ADDR	0xff

> +static u8 bq27000_regs[] = {
> +	0x00,	/* CONTROL	*/
> +	0x06,	/* TEMP		*/
> +	0xff,	/* INT TEMP - NA*/

I'd use the INVALID_REG_ADDR macro here.. Makes it more clear what is
going on (and you may change it to -1 in future, for example).

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v2 5/6] power: bq27xxx_battery: Add support for  additional bq27xxx family devices Pavel Machek <pavel@ucw.cz> - 2015-08-02 09:40 +0200

csiph-web