Groups > linux.kernel > #1198247

Re: [git pull] vfs.git spurious ENOTDIR fix

From	Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [git pull] vfs.git spurious ENOTDIR fix
Date	2015-08-02 03:00 +0200
Message-ID	<pSPN9-4Dt-37@gated-at.bofh.it> (permalink)
References	(4 earlier) <pSrrs-32C-7@gated-at.bofh.it> <pSzp0-6i2-1@gated-at.bofh.it> <pSHwe-1cH-11@gated-at.bofh.it> <pSPas-3Sy-71@gated-at.bofh.it> <pSPk5-44m-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Aug 1, 2015 at 5:23 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> Branch head should be at 97242f9, just to make sure you get
> the right one...

Ok, merged in my tree.

However, looking at this, I'm struck by how all the callers of
"link_path_walk()" tend to have very similar patterns wrt error
handling.

And I'm wondering - wouldn't it be nicer to extend that pattern a bit
more, and make the *callers* of link_path_walk() all do

        if (error) {
                if (nd->flags & LOOKUP_RCU) {
                        if (unlazy_walk(nd, NULL, 0))
                                error = -ECHILD;
                }
        }

and maybe even make that part of terminate_walk() that everybody calls
after getting here.

Because it's not just that "!d_can_lookup()" case that triggers it,
you also have that pattern in the RCU error case for may_lookup(), and
get_link().

So why don't we make the rule that *every* single error we get during
an RCU walk should do that unlazy_walk() and turn the error into
ECHILD on failure. Hmm? We're almost there as-is.

             Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[git pull] vfs.git spurious ENOTDIR fix Al Viro <viro@ZenIV.linux.org.uk> - 2015-08-02 02:20 +0200
  Re: [git pull] vfs.git spurious ENOTDIR fix Al Viro <viro@ZenIV.linux.org.uk> - 2015-08-02 02:30 +0200
    Re: [git pull] vfs.git spurious ENOTDIR fix Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-02 02:50 +0200
    Re: [git pull] vfs.git spurious ENOTDIR fix Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-02 03:00 +0200
      Re: [git pull] vfs.git spurious ENOTDIR fix Al Viro <viro@ZenIV.linux.org.uk> - 2015-08-02 03:50 +0200
        Re: [git pull] vfs.git spurious ENOTDIR fix Hugh Dickins <hughd@google.com> - 2015-08-02 06:10 +0200
          Re: [git pull] vfs.git spurious ENOTDIR fix Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-02 06:50 +0200
            Re: [git pull] vfs.git spurious ENOTDIR fix Hugh Dickins <hughd@google.com> - 2015-08-02 21:00 +0200
          Re: [git pull] vfs.git spurious ENOTDIR fix Al Viro <viro@ZenIV.linux.org.uk> - 2015-08-02 06:50 +0200
        Re: [git pull] vfs.git spurious ENOTDIR fix Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-02 04:50 +0200

csiph-web