Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1197976
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 05/15] drivers: input: Drop unlikely before IS_ERR(_OR_NULL) |
| Date | 2015-08-01 13:30 +0200 |
| Message-ID | <pSD9f-3gj-1@gated-at.bofh.it> (permalink) |
| References | <pSe1b-aE-3@gated-at.bofh.it> <pSe1d-aE-37@gated-at.bofh.it> <pSlP4-3eU-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 31-07-15, 09:58, Dmitry Torokhov wrote: > On Fri, Jul 31, 2015 at 02:08:25PM +0530, Viresh Kumar wrote: > > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there > > is no need to do that again from its callers. Drop it. > > I'd rather keep it as it documents the expected behavior and double > unlikely should work just fine. TBH, I don't really agree that it is there for documentation. The only purpose of such compiler flags is to try make code more efficient. Anyway, I got to this series as someone asked me to fix this for one of my patches which used unlikely(IS_ERR_OR_NULL()). And so I thought about fixing all sites that are doing double unlikely (that shouldn't hurt for sure). I will leave it to you. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 05/15] drivers: input: Drop unlikely before IS_ERR(_OR_NULL) Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-07-31 19:00 +0200
Re: [PATCH 05/15] drivers: input: Drop unlikely before IS_ERR(_OR_NULL) Viresh Kumar <viresh.kumar@linaro.org> - 2015-08-01 13:30 +0200
Re: [PATCH 05/15] drivers: input: Drop unlikely before IS_ERR(_OR_NULL) Pali Rohár <pali.rohar@gmail.com> - 2015-08-01 13:50 +0200
Re: [PATCH 05/15] drivers: input: Drop unlikely before IS_ERR(_OR_NULL) Pali Rohár <pali.rohar@gmail.com> - 2015-08-02 18:00 +0200
Re: [PATCH 05/15] drivers: input: Drop unlikely before IS_ERR(_OR_NULL) Pavel Machek <pavel@ucw.cz> - 2015-08-02 17:50 +0200
csiph-web