Groups > linux.kernel > #1197955

Re: [tip:x86/asm] x86/vm86: Clean up vm86.h includes

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [tip:x86/asm] x86/vm86: Clean up vm86.h includes
Date	Sat, 01 Aug 2015 10:30:02 +0200
Message-ID	<pSAl4-7Dn-5@gated-at.bofh.it> (permalink)
References	<pRspB-7rV-19@gated-at.bofh.it> <pSjkf-8dP-31@gated-at.bofh.it> <pSjWX-xJ-37@gated-at.bofh.it>
X-Original-To	Brian Gerst <brgerst@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=REndWLNRNwgEQN/7PLEg3CrVwwZqLM2zfE9rdYB/itY=; b=hcYsu4E6mcPqlJ0a0Ixe+1ABxNaievzAHuLoVxccNNzUzTnAqdKRSkGF/sWVyL5vaM mN9Fu+tiHkADf/INQ7fRIsoOB0PfQB+3n2/7aRrGlMvbK8/f+I1xY7LFoUAfKVkeHSrr YX/5BRZ8vG5wSzXpIRbMJhcJB/4xtr3PfxzyYNNBk6a2HEB3J8vh9GClDOTbYwcS8C8h DI4hOCRKBXHZ6nkRcL+NH/w1jphaBMVSaJ/KBdmjwXTWBJLKdj6qNogWcZeAlRTnj2nY 9GOz6VlmqE6t/5VbJUQCNNiFRk5HYrwmrCP+K3mhSzqq5XgvH8Ge1rFXNecGMKe4ffTb nDqA==
X-Received	by 10.180.187.193 with SMTP id fu1mr2253334wic.75.1438417369899; Sat, 01 Aug 2015 01:22:49 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	61
Organization	linux.* mail to news gateway
X-Original-Cc	Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@amacapital.net>, "H. Peter Anvin" <hpa@zytor.com>, Linus Torvalds <torvalds@linux-foundation.org>, Thomas Gleixner <tglx@linutronix.de>, Peter Zijlstra <peterz@infradead.org>, Denys Vlasenko <dvlasenk@redhat.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-tip-commits@vger.kernel.org
X-Original-Date	Sat, 1 Aug 2015 10:22:40 +0200
X-Original-Message-ID	<20150801082239.GA12202@gmail.com>
X-Original-References	<1438148483-11932-7-git-send-email-brgerst@gmail.com> <tip-ba3e127ec105e790eeec4034d9769e018e4a1b54@git.kernel.org> <CAMzpN2i8pCANnbgo93wDn-uBvBKMqyLbLzGsd5wzQNh-dwFsaQ@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1197955

Show key headers only | View raw

* Brian Gerst <brgerst@gmail.com> wrote:

> On Fri, Jul 31, 2015 at 10:04 AM, tip-bot for Brian Gerst
> <tipbot@zytor.com> wrote:
> > Commit-ID:  ba3e127ec105e790eeec4034d9769e018e4a1b54
> > Gitweb:     http://git.kernel.org/tip/ba3e127ec105e790eeec4034d9769e018e4a1b54
> > Author:     Brian Gerst <brgerst@gmail.com>
> > AuthorDate: Wed, 29 Jul 2015 01:41:21 -0400
> > Committer:  Ingo Molnar <mingo@kernel.org>
> > CommitDate: Fri, 31 Jul 2015 13:31:10 +0200
> >
> > x86/vm86: Clean up vm86.h includes
> >
> > vm86.h was being implicitly included in alot of places via
> > processor.h, which in turn got it from math_emu.h.  Break that
> > chain and explicitly include vm86.h in all files that need it.
> > Also remove unused vm86 field from math_emu_info.
> >
> > Signed-off-by: Brian Gerst <brgerst@gmail.com>
> > Cc: Andy Lutomirski <luto@amacapital.net>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Denys Vlasenko <dvlasenk@redhat.com>
> > Cc: H. Peter Anvin <hpa@zytor.com>
> > Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Link: http://lkml.kernel.org/r/1438148483-11932-7-git-send-email-brgerst@gmail.com
> > [ Fixed build failure. ]
> > Signed-off-by: Ingo Molnar <mingo@kernel.org>
> 
> 
> > diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> > index f35ed53..d4cda5e 100644
> > --- a/drivers/scsi/dpt_i2o.c
> > +++ b/drivers/scsi/dpt_i2o.c
> > @@ -1924,6 +1924,9 @@ static void adpt_alpha_info(sysInfo_S* si)
> >  #endif
> >
> >  #if defined __i386__
> > +
> > +#include <uapi/asm/vm86.h>
> > +
> >  static void adpt_i386_info(sysInfo_S* si)
> >  {
> >         // This is all the info we need for now
> 
> It would have been better to just remove the the CPU_* defines from
> this driver.  boot_cpu_data.x86 is simply the family ID from CPUID,
> and nowhere else uses defines like this.

Please send a followup patch for that.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 6/8] x86/vm86: Clean up vm86.h includes Brian Gerst <brgerst@gmail.com> - 2015-07-29 07:50 +0200
  Re: [tip:x86/asm] x86/vm86: Clean up vm86.h includes Ingo Molnar <mingo@kernel.org> - 2015-08-01 10:30 +0200

csiph-web