Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1196575
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: macintosh/ans-lcd: fix build failure after module_init/exit relocation |
| Date | 2015-07-31 06:20 +0200 |
| Message-ID | <pS9Xz-2S8-9@gated-at.bofh.it> (permalink) |
| References | <pNdSa-6GQ-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 2015-17-07 at 13:20:31 UTC, Luis Henriques wrote:
> After commit 0fd972a7d91d ("module: relocate module_init from init.h to module.h")
> ans-lcd module fails to build with:
>
> drivers/macintosh/ans-lcd.c:201:1: warning: data definition has no type or storage class [enabled by default]
> module_init(anslcd_init);
> ^
> drivers/macintosh/ans-lcd.c:201:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
> drivers/macintosh/ans-lcd.c:201:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/macintosh/ans-lcd.c:202:1: warning: data definition has no type or storage class [enabled by default]
> module_exit(anslcd_exit);
> ^
> drivers/macintosh/ans-lcd.c:202:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int]
> drivers/macintosh/ans-lcd.c:202:1: warning: parameter names (without types) in function declaration [enabled by default]
> drivers/macintosh/ans-lcd.c:155:1: warning: 'anslcd_init' defined but not used [-Wunused-function]
> anslcd_init(void)
> ^
> drivers/macintosh/ans-lcd.c:195:1: warning: 'anslcd_exit' defined but not used [-Wunused-function]
> anslcd_exit(void)
> ^
>
> This commit fixes it by replacing linux/init.h by linux/module.h.
>
> Fixes: 0fd972a7d91d ("module: relocate module_init from init.h to module.h")
> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
> Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/120d200a86273d1840d0
cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: macintosh/ans-lcd: fix build failure after module_init/exit relocation Michael Ellerman <mpe@ellerman.id.au> - 2015-07-31 06:20 +0200
csiph-web