Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1196410

Re: [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for the FSL QorIQ DPAA FMan

Show all headers | View raw

On Thu, 2015-07-30 at 07:32 +0300, Igal.Liberman wrote:
> +fman0:  fman@400000{
> +     #address-cells = <1>;
> +     #size-cells = <1>;
> +     cell-index = <0>;
> +     compatible = "fsl,fman";
> +     ranges = <0 0x400000 0x100000>;
> +     reg = <0x400000 0x100000>;
> +     interrupts = <96 2 0 0>, <16 2 1 1>;
> +     clocks = <&clockgen 3 0>;
> +     clock-names = "fm0clk";

clock-names should be "fmanclk" as per the binding.  And why would you want 
the driver to have to encode the fman index into the name in order to look 
the clock up by name?

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for the  FSL QorIQ DPAA FMan Scott Wood <scottwood@freescale.com> - 2015-07-30 22:10 +0200
  RE: [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for the FSL  QorIQ DPAA FMan Liberman Igal <Igal.Liberman@freescale.com> - 2015-08-03 09:40 +0200

csiph-web