Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1196404
| From | Rasmus Villemoes <linux@rasmusvillemoes.dk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] lib/string_helpers: clarify esc arg in string_escape_mem |
| Date | 2015-07-30 22:00 +0200 |
| Message-ID | <pS29J-8f1-13@gated-at.bofh.it> (permalink) |
| References | <pPxWq-4F6-17@gated-at.bofh.it> |
| Organization | D03 |
On Fri, Jul 24 2015, Kees Cook <keescook@chromium.org> wrote: > The esc argument is used to reduce which characters will be escaped. > For example, using " " with ESCAPE_SPACE will not produce any escaped > spaces. > Yeah, I've been confused by this more than once - the old description and the parameter name suggest that the esc string contains additional characters to escape, not the other way around. Could we also rename the parameter 'only' or something like that? In any case, Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] lib/string_helpers: clarify esc arg in string_escape_mem Kees Cook <keescook@chromium.org> - 2015-07-24 01:20 +0200 Re: [PATCH] lib/string_helpers: clarify esc arg in string_escape_mem Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-07-30 22:00 +0200
csiph-web