Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1194073

Re: [PATCH v2 1/3] gpio: defer probe if pinctrl cannot be found

Show all headers | View raw

On Tue, Jul 14, 2015 at 10:29 AM, Tomeu Vizoso
<tomeu.vizoso@collabora.com> wrote:

> When an OF node has a pin range for its GPIOs, return -EPROBE_DEFER if
> the pin controller isn't available.
>
> Otherwise, the GPIO range wouldn't be set at all unless the pin
> controller probed always before the GPIO chip.
>
> With this change, the probe of the GPIO chip will be deferred and will
> be retried at a later point, hopefully once the pin controller has been
> registered and probed already.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
>
> Changes in v2:
> - Don't defer probe if the pinctrl node is disabled

Sorry for the delay.

This looks like the right thing to do, I was just worried that it would have
undesired semantic or probe order effects on some platforms, but I think
this is one of these cases where I just have to apply this and see what
happens when people test it in linux-next.

So, patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/3] gpio: defer probe if pinctrl cannot be found Linus Walleij <linus.walleij@linaro.org> - 2015-07-28 12:30 +0200

csiph-web