Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1196131
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Rob Herring <robherring2@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] backlight: pm8941-wled: Add default-brightness property |
| Date | Thu, 30 Jul 2015 17:30:03 +0200 |
| Message-ID | <pRXWr-2jR-27@gated-at.bofh.it> (permalink) |
| References | <pPuOS-8cL-11@gated-at.bofh.it> <pPN58-1hL-15@gated-at.bofh.it> <pRJqq-6tK-11@gated-at.bofh.it> |
| X-Original-To | Bjorn Andersson <bjorn.andersson@sonymobile.com> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=wnfjDwvIgZSWB+OISD24ElsBNjiF78DXselaoGBXJmY=; b=iuYFdvpgE5ieR/la+PzDvJs0OO2RfU0BfzSQSacHa2uiInSmo8jJPPmI0obf3crYCr SQHrXKk8t5TaeBmO010NHFgmut8llvQ/Hi+RuVU8dfTE71Bnr/hA9X6kqa54P+NYHQrX uFQAwQQJrUkU9ILRxMdbj4u3zlFO8Jwevafxu/+ldmmZveMrBrAklQiibSeUzlNe35uw GBALaCdLlXjwuuCEZjimiTIPmi7J1RfdJRUUWVH7dsmG5+P9V2mdToE4iJEJKABtwB7O WEKETaejdCJLj3NMR5GNYaE2RsrysmpIdSnA5ZRZtEqMmKLlA8a7ro/T258fNpDavyYW uY9w== |
| X-Received | by 10.13.218.71 with SMTP id c68mr51962891ywe.126.1438269998578; Thu, 30 Jul 2015 08:26:38 -0700 (PDT) |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 63 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Jingoo Han <jingoohan1@gmail.com>, Lee Jones <lee.jones@linaro.org>, Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>, Tomi Valkeinen <tomi.valkeinen@ti.com>, Rob Clark <robdclark@gmail.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org> |
| X-Original-Date | Thu, 30 Jul 2015 10:26:19 -0500 |
| X-Original-Message-ID | <CAL_JsqJYxDROqbv-wh37=MjwbsEtrYKFTvC1NfneonLH2_gL2A@mail.gmail.com> |
| X-Original-References | <1437681127-15760-1-git-send-email-bjorn.andersson@sonymobile.com> <CAL_JsqKxdF5sj=edURFLDCk1OyCJR-w6+STL4r3zM6+be3tjhg@mail.gmail.com> <20150729235139.GC6519@usrtlx11787.corpusers.net> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | aioe.org linux.kernel:1196131 |
Show key headers only | View raw
On Wed, Jul 29, 2015 at 6:51 PM, Bjorn Andersson <bjorn.andersson@sonymobile.com> wrote: > On Fri 24 Jul 08:29 PDT 2015, Rob Herring wrote: > >> On Thu, Jul 23, 2015 at 2:52 PM, Bjorn Andersson >> <bjorn.andersson@sonymobile.com> wrote: >> > Add the possibility of specifying the default brightness in DT. >> > >> > Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com> >> > --- >> > >> > This depends on the patch moving pm8941-wled to backlight [1]. The dt property >> > is used by several other backlight drivers, so I considered this to be a >> > "common" property and it's hence not prefixed with "qcom,". >> >> Well, we have "default-brightness" and "default-brightness-level" used >> by 1 driver each. But default-brightness-level is much more commonly >> used (in dts files) since it is in the pwm backlight binding, so we >> should go with it. I'd like to see this moved to a common backlight >> doc. >> > > As I looked at these, the default-brightness used in tps65217 is a value > between 0 and 100, so that can be interpreted as a percentage. > > The pwm binding however uses a separate array of "brightness-levels" and > then default-brightness-level is supposed to be an index into that > array. Uggg. I missed that minor detail... > As we're trying to specify a default brightness within the range [0, > max_brightness) the latter doesn't make much sense. > > Therefor my suggestion is that we make the "default-brightness" the > common property and we define it as a percentage of [0,max_brightness). Okay. I wonder if we should have units such as "default-brightness-percentage" or "default-brightness-%" so it is clear. Otherwise, we might have some people doing a range of [0,max]. The former is a bit long and the latter is a bit unusual. >> Really, I think all the backlight documentation should be merged with >> LEDs docs. Things like "default-on" are common. But I won't ask to do >> that here. > > I think the backlight framework should be merged with the LED framework. > There's several hw blocks that are split between the two, with an mfd > tying them together... Fully agree. BTW, doing that doesn't have to be in sync between the bindings and drivers. Of course, if we've designed the bindings with sub devices to fit the MFD structure, then that is another problem. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH] backlight: pm8941-wled: Add default-brightness property Rob Herring <robherring2@gmail.com> - 2015-07-30 17:30 +0200
csiph-web