Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1195905

Re: [PATCH 2/7] iio: bmg160: Use i2c regmap instead of direct i2c access

From Paul Bolle <pebolle@tiscali.nl>
Newsgroups linux.kernel
Subject Re: [PATCH 2/7] iio: bmg160: Use i2c regmap instead of direct i2c access
Date 2015-07-30 12:50 +0200
Message-ID <pRTzr-4iK-11@gated-at.bofh.it> (permalink)
References <pRzU5-1hb-3@gated-at.bofh.it> <pRzU6-1hb-27@gated-at.bofh.it> <pREqK-7Sb-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On wo, 2015-07-29 at 20:37 +0200, Markus Pargmann wrote:
> On Wed, Jul 29, 2015 at 03:46:04PM +0200, Markus Pargmann wrote:
> > +struct regmap_config bmg160_regmap_i2c_conf = {
> 
> This should probably be static const ...

Likewise for "bmg160_regmap_conf", which you add in 7/7, right?

Thanks,


Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/7] iio: bmg160: Add SPI connection Markus Pargmann <mpa@pengutronix.de> - 2015-07-29 15:50 +0200
  [PATCH 4/7] iio: bmg160: Use generic dev_drvdata Markus Pargmann <mpa@pengutronix.de> - 2015-07-29 15:50 +0200
  [PATCH 3/7] iio: bmg160: Remove i2c_client from data struct Markus Pargmann <mpa@pengutronix.de> - 2015-07-29 15:50 +0200
  [PATCH 1/7] iio: bmg160: IIO_BUFFER and IIO_TRIGGERED_BUFFER are required Markus Pargmann <mpa@pengutronix.de> - 2015-07-29 15:50 +0200
    Re: [PATCH 1/7] iio: bmg160: IIO_BUFFER and IIO_TRIGGERED_BUFFER are  required Jonathan Cameron <jic23@kernel.org> - 2015-08-02 20:40 +0200
  [PATCH 5/7] iio: bmg160: Remove remaining uses of i2c_client Markus Pargmann <mpa@pengutronix.de> - 2015-07-29 15:50 +0200
  [PATCH 2/7] iio: bmg160: Use i2c regmap instead of direct i2c access Markus Pargmann <mpa@pengutronix.de> - 2015-07-29 15:50 +0200
    Re: [PATCH 2/7] iio: bmg160: Use i2c regmap instead of direct i2c  access Paul Bolle <pebolle@tiscali.nl> - 2015-07-30 12:50 +0200
  [PATCH 6/7] iio: bmg160: Separate i2c and core driver Markus Pargmann <mpa@pengutronix.de> - 2015-07-29 15:50 +0200

csiph-web