Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1195772

Re: [PATCH] firmware: fix wrong memory deallocation in fw_add_devm_name()

Show all headers | View raw

On Wed, Jul 29, 2015 at 4:26 PM, Vladimir Zapolskiy <vz@mleia.com> wrote:
> Device resource data allocated with devres_alloc() must be deallocated
> by devres_free().
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>

Acked-by: Ming Lei <ming.lei@canonical.com>

> ---
>  drivers/base/firmware_class.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
> index 894bda1..8524450 100644
> --- a/drivers/base/firmware_class.c
> +++ b/drivers/base/firmware_class.c
> @@ -443,7 +443,7 @@ static int fw_add_devm_name(struct device *dev, const char *name)
>                 return -ENOMEM;
>         fwn->name = kstrdup_const(name, GFP_KERNEL);
>         if (!fwn->name) {
> -               kfree(fwn);
> +               devres_free(fwn);
>                 return -ENOMEM;
>         }
>
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] firmware: fix wrong memory deallocation in fw_add_devm_name() Vladimir Zapolskiy <vz@mleia.com> - 2015-07-29 22:30 +0200
  Re: [PATCH] firmware: fix wrong memory deallocation in fw_add_devm_name() Ming Lei <ming.lei@canonical.com> - 2015-07-30 09:50 +0200

csiph-web