Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1195770

Re: [PATCH v5 2/4] x86/ldt: Make modify_ldt synchronous

Show all headers | View raw

On Mon, Jul 27, 2015 at 10:29:39PM -0700, Andy Lutomirski wrote:
> modify_ldt has questionable locking and does not synchronize
> threads.  Improve it: redesign the locking and synchronize all
> threads' LDTs using an IPI on all modifications.
> 
> This will dramatically slow down modify_ldt in multithreaded
> programs, but there shouldn't be any multithreaded programs that
> care about modify_ldt's performance in the first place.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Andy Lutomirski <luto@kernel.org>

I've stared a lot at this one these days, I guess a

Reviewed-by: Borislav Petkov <bp@suse.de>

is in order.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 0/4] x86: modify_ldt improvement, test, and config option Andy Lutomirski <luto@kernel.org> - 2015-07-28 07:40 +0200
  [PATCH v5 2/4] x86/ldt: Make modify_ldt synchronous Andy Lutomirski <luto@kernel.org> - 2015-07-28 07:40 +0200
    Re: [PATCH v5 2/4] x86/ldt: Make modify_ldt synchronous Borislav Petkov <bp@alien8.de> - 2015-07-30 09:50 +0200
    Re: [PATCH v5 2/4] x86/ldt: Make modify_ldt synchronous Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-07-30 20:40 +0200
      Re: [PATCH v5 2/4] x86/ldt: Make modify_ldt synchronous Andy Lutomirski <luto@amacapital.net> - 2015-07-30 21:30 +0200
        Re: [PATCH v5 2/4] x86/ldt: Make modify_ldt synchronous Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-07-31 19:00 +0200
  [PATCH v5 3/4] selftests/x86, x86/ldt: Add a selftest for modify_ldt Andy Lutomirski <luto@kernel.org> - 2015-07-28 07:40 +0200
  [PATCH v5 4/4] x86/ldt: Make modify_ldt optional Andy Lutomirski <luto@kernel.org> - 2015-07-28 07:40 +0200
    Re: [PATCH v5 4/4] x86/ldt: Make modify_ldt optional Kees Cook <keescook@chromium.org> - 2015-07-28 22:50 +0200
      Re: [PATCH v5 4/4] x86/ldt: Make modify_ldt optional Willy Tarreau <w@1wt.eu> - 2015-07-28 23:00 +0200
  Re: [PATCH v5 0/4] x86: modify_ldt improvement, test, and config  option Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-07-30 18:00 +0200
    Re: [PATCH v5 0/4] x86: modify_ldt improvement, test, and config  option Borislav Petkov <bp@alien8.de> - 2015-07-30 18:10 +0200

csiph-web