Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1195722

Re: [RFC][PATCH 3/7] avr32: Remove finish_arch_switch()

From Hans-Christian Egtvedt <egtvedt@samfundet.no>
Newsgroups linux.kernel
Subject Re: [RFC][PATCH 3/7] avr32: Remove finish_arch_switch()
Date 2015-07-30 07:50 +0200
Message-ID <pROT8-5YY-13@gated-at.bofh.it> (permalink)
References <pRFd7-AH-3@gated-at.bofh.it> <pRFd8-AH-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Around Wed 29 Jul 2015 21:08:51 +0200 or thereabout, Peter Zijlstra wrote:
> Fold the tracing hook into switch_to() in order to remove
> finish_arch_switch().

AFAICT this should work, I do not have a nexus debugger to verify behavior.

> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>

Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>

> ---
>  arch/avr32/include/asm/switch_to.h |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> --- a/arch/avr32/include/asm/switch_to.h
> +++ b/arch/avr32/include/asm/switch_to.h
> @@ -15,11 +15,13 @@
>   */
>  #ifdef CONFIG_OWNERSHIP_TRACE
>  #include <asm/ocd.h>
> -#define finish_arch_switch(prev)			\
> +#define ocd_switch(prev, next)				\
>  	do {						\
>  		ocd_write(PID, prev->pid);		\
> -		ocd_write(PID, current->pid);		\
> +		ocd_write(PID, next->pid);		\
>  	} while(0)
> +#else
> +#define ocd_switch(prev, next)
>  #endif
>  
>  /*
> @@ -38,6 +40,7 @@ extern struct task_struct *__switch_to(s
>  				       struct cpu_context *);
>  #define switch_to(prev, next, last)					\
>  	do {								\
> +		ocd_switch(prev, next);					\
>  		last = __switch_to(prev, &prev->thread.cpu_context + 1,	\
>  				   &next->thread.cpu_context);		\
>  	} while (0)
-- 
mvh
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC][PATCH 0/7] sched: Remove finish_arch_switch() Peter Zijlstra <peterz@infradead.org> - 2015-07-29 21:30 +0200
  [RFC][PATCH 3/7] avr32: Remove finish_arch_switch() Peter Zijlstra <peterz@infradead.org> - 2015-07-29 21:30 +0200
    Re: [RFC][PATCH 3/7] avr32: Remove finish_arch_switch() Hans-Christian Egtvedt <egtvedt@samfundet.no> - 2015-07-30 07:50 +0200
  [RFC][PATCH 4/7] score: Remove finish_arch_switch() Peter Zijlstra <peterz@infradead.org> - 2015-07-29 21:30 +0200
  [RFC][PATCH 7/7] sched: Remove finish_arch_switch() Peter Zijlstra <peterz@infradead.org> - 2015-07-29 21:30 +0200
  Re: [RFC][PATCH 0/7] sched: Remove finish_arch_switch() Peter Zijlstra <peterz@infradead.org> - 2015-07-30 12:00 +0200

csiph-web