Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1195459

Re: [PATCH v3 0/3] x86/pci/intel-mid-pci: fix to get eMMC detected

Show all headers | View raw

On Wed, 29 Jul 2015, Andy Shevchenko wrote:

> On Intel Edison we have an interesting implementation of x86 platform without
> legacy PIC and with specific PCI. There are devices which are not using
> interrupt line 0, but have it assigned in the PCI configuration. By default
> first come gets it, though the first eMMC host controller is the actual user
> for IRQ0. 
> 
> So, this series provides a quirk (patch 1) to resolve the issue, a small fix of
> error code (patch 2), and a sparse warning fix (patch 3).
> 
> Changelog v3:
> - address Thomas' comments
> - massage changelog (what Thomas proposed)
> 
> Andy Shevchenko (3):
>   x86/pci/intel_mid_pci: work around for IRQ0 assignment
>   x86/pci/intel_mid_pci: propagate actual return code
>   x86/pci/intel_mid_pci: fix a sparse warning

I've picked them up. If you get the tip-bot mails, you might notice a
few edits on the changelogs. 

    - Sentence starts with an upper case letter.

    - You cannot fix a sparse warning.

    - "This patch does ...." is just horrible. When one reads a patch
      he already knows that it is a patch.

Please avoid these things in the future.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/3] x86/pci/intel-mid-pci: fix to get eMMC detected Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-07-29 11:20 +0200
  [PATCH v3 2/3] x86/pci/intel_mid_pci: propagate actual return code Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-07-29 11:20 +0200
    [tip:x86/platform] x86/pci/intel_mid_pci:   Propagate actual return code tip-bot for Andy Shevchenko <tipbot@zytor.com> - 2015-07-29 21:40 +0200
  Re: [PATCH v3 0/3] x86/pci/intel-mid-pci: fix to get eMMC detected Thomas Gleixner <tglx@linutronix.de> - 2015-07-29 21:40 +0200

csiph-web