Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1195468

Re: [PATCH v2] acpi: Use kstrtoul() instead of strtoul()/simple_strtoul()

Show all headers | View raw

Hi Guenter,

On Wed, Jul 29, 2015 at 8:38 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> On 07/29/2015 10:51 AM, Moore, Robert wrote:
>>
>>
>>
>>> -----Original Message-----
>>> From: Guenter Roeck [mailto:linux@roeck-us.net]
>>> Sent: Monday, July 27, 2015 5:32 PM
>>> To: rjw@rjwysocki.net
>>> Cc: lenb@kernel.org; Moore, Robert; Zheng, Lv;
>>> linux-acpi@vger.kernel.org;
>>> linux-kernel@vger.kernel.org; devel@acpica.org; Guenter Roeck
>>> Subject: [PATCH v2] acpi: Use kstrtoul() instead of
>>> strtoul()/simple_strtoul()
>>>
>>> simple_strtoul() is deprecated; replace with kstrtoul() and kstrtouint().
>>
>>
>> The ACPICA code is os-independent and cannot use these functions (at least
>> not directly).
>>
>>
> Odd argument, given that kstrtoul() is used already in the acpi code.

Boib is right, the change in sysfs.c is OK, but the one in evgpeinit.c
isn't (this code is automatically generated from the upstream ACPICA
source and manual updates of it are painful).

You might provide a strtoul() wrapper around kstrtoul() instead of its
definition in acpi/platform/aclinux.h, though.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] acpi: Use kstrtoul() instead of strtoul()/simple_strtoul() Guenter Roeck <linux@roeck-us.net> - 2015-07-28 02:40 +0200
  RE: [PATCH v2] acpi: Use kstrtoul() instead of  strtoul()/simple_strtoul() "Moore, Robert" <robert.moore@intel.com> - 2015-07-29 21:40 +0200
    Re: [PATCH v2] acpi: Use kstrtoul() instead of strtoul()/simple_strtoul() Guenter Roeck <linux@roeck-us.net> - 2015-07-29 22:00 +0200
      Re: [PATCH v2] acpi: Use kstrtoul() instead of strtoul()/simple_strtoul() "Rafael J. Wysocki" <rafael@kernel.org> - 2015-07-29 22:10 +0200
        Re: [PATCH v2] acpi: Use kstrtoul() instead of strtoul()/simple_strtoul() Guenter Roeck <linux@roeck-us.net> - 2015-07-29 22:40 +0200
  Re: [PATCH v2] acpi: Use kstrtoul() instead of strtoul()/simple_strtoul() "Rafael J. Wysocki" <rafael@kernel.org> - 2015-07-29 22:00 +0200
  Re: [PATCH v2] acpi: Use kstrtoul() instead of  strtoul()/simple_strtoul() Pavel Machek <pavel@ucw.cz> - 2015-08-02 09:20 +0200
    Re: [PATCH v2] acpi: Use kstrtoul() instead of strtoul()/simple_strtoul() Guenter Roeck <linux@roeck-us.net> - 2015-08-02 10:30 +0200

csiph-web